Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'Invoice Number' field in Opening Invoice Creation Tool #28844

Merged

Conversation

nemesis189
Copy link
Contributor

@nemesis189 nemesis189 commented Dec 13, 2021

Description:

  • A field to store the Invoice Number of the invoices being imported in the Open Invoice Creation Tool has been added
  • If the field has a name the invoice created will have that name instead of the conventional naming series stored in ERPNext
  • If empty the series is continued from the last invoice of the series
Field is populated:
Field is empty:

Steps:

  1. Open Opening Invoice Creation Tool
  2. Select a Company and Type of invoice, in this case - Sales
  3. Add row in Items table with a customer, outstanding amount and add the invoice name after expanding the row
  4. Check the newly created invoice in sales invoice list

docs: https://docs.erpnext.com/docs/v13/user/manual/en/accounts/articles/opening-invoice-creation-tool

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #28844 (dd33c95) into develop (9a644f6) will increase coverage by 8.73%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #28844      +/-   ##
===========================================
+ Coverage    46.80%   55.53%   +8.73%     
===========================================
  Files         1122     1125       +3     
  Lines        66777    66987     +210     
===========================================
+ Hits         31255    37202    +5947     
+ Misses       35522    29785    -5737     
Impacted Files Coverage Δ
...ice_creation_tool/opening_invoice_creation_tool.py 61.64% <100.00%> (+0.80%) ⬆️
...nts/doctype/accounts_settings/accounts_settings.py 97.50% <0.00%> (-2.50%) ⬇️
.../hr/doctype/upload_attendance/upload_attendance.py 44.69% <0.00%> (-1.52%) ⬇️
...next/accounts/doctype/subscription/subscription.py 81.74% <0.00%> (-0.57%) ⬇️
erpnext/hooks.py 0.00% <0.00%> (ø)
erpnext/regional/saudi_arabia/setup.py 0.00% <0.00%> (ø)
...next/support/report/issue_summary/issue_summary.py 0.00% <0.00%> (ø)
...xt/setup/setup_wizard/operations/defaults_setup.py 0.00% <0.00%> (ø)
.../report/accounts_receivable/accounts_receivable.py 68.37% <0.00%> (ø)
.../report/tds_payable_monthly/tds_payable_monthly.py 0.00% <0.00%> (ø)
... and 197 more

Copy link
Member

@nextchamp-saqib nextchamp-saqib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_child_names is True by default

@nemesis189 nemesis189 requested review from nextchamp-saqib and removed request for deepeshgarg007 December 14, 2021 07:39
@nextchamp-saqib nextchamp-saqib enabled auto-merge (squash) December 15, 2021 04:59
@harshit-30
Copy link
Contributor

harshit-30 commented Dec 16, 2021

@nemesis189 the Invoice Number field should be visible in the grid view of the table. Inserting every invoice by opening the child table is not very intuitive.

Cc. @nextchamp-saqib

@nemesis189
Copy link
Contributor Author

@nemesis189 the Invoice Number field should be visible in the grid view of the table. Inserting every invoice by opening the child table is not very intuitive.

Cc. @nextchamp-saqib

Done.
PR: #28938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants