-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: postgres unittests configurations #28952
Conversation
This is technically ready for review but can't be merged till frappe/frappe#15354 is merged, hence marking it draft for now. Also I need to make this CI workflow conditional for postgres PRs. |
Codecov Report
@@ Coverage Diff @@
## develop #28952 +/- ##
===========================================
+ Coverage 49.69% 55.68% +5.99%
===========================================
Files 1131 1131
Lines 67513 67516 +3
===========================================
+ Hits 33548 37597 +4049
+ Misses 33965 29919 -4046
|
note: Reverted change to HSN code creation since it appears that something else is rolling back full transaction as apparent from CI run on this commit: d864972 https://github.com/frappe/erpnext/runs/4684613490?check_suite_focus=true This is the root cause behind HSN codes not getting created properly in tests. I can fix this here but feels like this needs to be handled better by the framework. Improper error handling is causing rollback. Well, actually both changes are required, this kinda error handling in regional setup will cause weird state in DB. erpnext/erpnext/regional/india/setup.py Lines 715 to 723 in d864972
cc: @gavindsouza @deepeshgarg007 for postgres DB we are just rolling back everything on SQL exception 😐 |
This reverts commit 142558c.
This reverts commit d864972.
Merging just the CI change for now, rest will require a fix at framework level. |
Co-authored-by: Ankush Menat <ankush@frappe.io>
Co-authored-by: Ankush Menat <ankush@frappe.io>
This PR simply enables running of postgres tests without doing anything else. It requires a couple of minor commits in Frappe repository: https://github.com/cpdeethree/frappe/tree/enable-postgres-tests
These commits are also included on the larger frappe and erpnext pr's with changes for postgres support for ERPNext:
#28359
Thus (minus the DEBUG branch pointer commit), all changes here are strict subsets of the above PR's
Depends on: frappe/frappe#15354