-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Stock Ageing Report - Negative Opening Stock #28966
Merged
marination
merged 9 commits into
frappe:develop
from
marination:stock-ageing-negative-stock
Dec 28, 2021
Merged
fix: Stock Ageing Report - Negative Opening Stock #28966
marination
merged 9 commits into
frappe:develop
from
marination:stock-ageing-negative-stock
Dec 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consider negative opening stock in logic and neutralise it with +ve stock - minor code refactor: class for FIFOSlots to generate chronological FIFO queue
- args passed to wrong function - missing space around '='
Codecov Report
@@ Coverage Diff @@
## develop #28966 +/- ##
============================================
+ Coverage 44.95% 55.54% +10.59%
============================================
Files 1128 1128
Lines 67295 67331 +36
============================================
+ Hits 30251 37400 +7149
+ Misses 37044 29931 -7113
|
Sider failing on .md file, remark-lint was disabled for this repo, idk why its still failing |
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
✅ Backports have been created
|
marination
added a commit
that referenced
this pull request
Dec 28, 2021
…-28966 fix: Stock Ageing Report - Negative Opening Stock (backport #28966)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Consider ledger:
Fix:
FIFOSlots
to generate chronological FIFO queueUsage
Dependencies/To Test:
show ageing data
checked