Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Convert Item links to Website Item links in Item Card Group template data #28985

Merged
merged 6 commits into from
Dec 22, 2021

Conversation

marination
Copy link
Collaborator

@marination marination commented Dec 21, 2021

Issue:

  • Item Cards did not redirect anywhere, this is because Item master does not have the route field anymore
  • This template was still fetching Item master data

Fix:

  • Changed link option to Website Item in Item card group template
  • patch to convert pre-existing data
  • 2021-12-21 15 55 14

To test:

  • Make a web page and use Item card Group page block, add items to the block.
  • check if the cards are responsive on the web page

…late data

- Changed link option to Website Item in Item card group template
- patch to convert pre-existing data
@marination marination added the e-commerce-fix E-commerce PRs that need to be front ported to develop label Dec 21, 2021
@marination marination added this to the v13.18 milestone Dec 22, 2021
@marination
Copy link
Collaborator Author

marination commented Dec 22, 2021

server test failure is unrelated, have notified HR maintainer to fix it (test_against_leave_application_validation_after_submit)

@marination marination merged commit 808e40c into frappe:version-13-hotfix Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-commerce-fix E-commerce PRs that need to be front ported to develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant