-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provision to assign multiple payroll cost centers against a single employee #29024
Merged
ruchamahabal
merged 6 commits into
frappe:develop
from
nabinhait:multiple-cost-centers-against-employee
Dec 28, 2021
Merged
feat: Provision to assign multiple payroll cost centers against a single employee #29024
ruchamahabal
merged 6 commits into
frappe:develop
from
nabinhait:multiple-cost-centers-against-employee
Dec 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
multiple-cost-centers-against-employee
branch
from
December 28, 2021 03:24
59ae4aa
to
8226ea6
Compare
Not fixing sider issues for frappe.qb. Not helpful |
Raised a PR for fixing unrelated failing tests: #29051 |
Codecov Report
@@ Coverage Diff @@
## develop #29024 +/- ##
===========================================
- Coverage 55.67% 55.57% -0.10%
===========================================
Files 1128 1129 +1
Lines 67335 67379 +44
===========================================
- Hits 37488 37447 -41
- Misses 29847 29932 +85
|
ruchamahabal
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing:
Earlier we had a provision to assign a payroll cost centre against an Employee via Department/Employee master.
New Feature:
Now you can assign multiple cost centres against an employee. This is a very common use-case, where one employee contributes to multiple departments or cost centers, hence the salary expenses associated with that employee should be distributed against multiple cost centres.
Docs: https://docs.erpnext.com/compare?wiki_page=docs/v13/user/manual/en/human-resources/payroll-entry&&compare=1a037a4c97 (the docs changes are already live by mistake)