-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect posting time fetching incorrect qty #29103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mergifyio backport version-13-hotfix |
🟠 Waiting for conditions to match
|
Codecov Report
@@ Coverage Diff @@
## develop #29103 +/- ##
===========================================
+ Coverage 55.66% 55.70% +0.04%
===========================================
Files 1129 1131 +2
Lines 67471 67550 +79
===========================================
+ Hits 37555 37629 +74
- Misses 29916 29921 +5
|
ankush
approved these changes
Jan 3, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2022
(cherry picked from commit f02e6b4)
✅ Backports have been created
|
rohitwaghchaure
added a commit
that referenced
this pull request
Jan 3, 2022
…-29103 fix: incorrect posting time fetching incorrect qty (backport #29103)
ChillarAnand
pushed a commit
to ChillarAnand/erpnext
that referenced
this pull request
Jan 3, 2022
@Mergifyio backport version-13-pre-release |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 5, 2022
(cherry picked from commit f02e6b4)
rohitwaghchaure
added a commit
that referenced
this pull request
Jan 5, 2022
…se/pr-29103 fix: incorrect posting time fetching incorrect qty (backport #29103)
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
conncampbell
pushed a commit
to conncampbell/erpnext
that referenced
this pull request
Jan 9, 2022
fproldan
pushed a commit
to fproldan/erpnext
that referenced
this pull request
Jan 2, 2023
(cherry picked from commit f02e6b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_stock_balance method fetches incorrect qty if the posting time is set as 00:00:00
Issue
Somehow system ignoring the value 0:00:00
After Fix
To fix the issue added condition that
if posting_time is None