fix: map Accounting Dimensions for Bank Entry against Payroll Entry #29142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport version-13-hotfix version-13-pre-release |
🟠 Waiting for conditions to match
|
|
Unrelated test failures |
|
Failing test cases are unrelated, merging this PR |
This was referenced Jan 4, 2022
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Jan 4, 2022
…-29142 fix: map Accounting Dimensions for Bank Entry against Payroll Entry (backport #29142)
deepeshgarg007
added a commit
that referenced
this pull request
Jan 4, 2022
…se/pr-29142 fix: map Accounting Dimensions for Bank Entry against Payroll Entry (backport #29142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Replicate:
Create an Accounting Dimension eg: Branch
Create a Payroll Entry, submit salary slips.
Make Bank Entry against Payroll Entry. This will create a Journal Entry to book salary payment.
This Journal Entry won't get submitted due to missing mandatory accounting dimension.
Fix:
Accounting Dimensions get mapped while making accrual JV on salary slip submission but not when making Bank Entry. Map accounting dimensions in this method too.