-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UX): Option to exclude holidays while marking monthly attendance #29185
Merged
ruchamahabal
merged 2 commits into
frappe:develop
from
ruchamahabal:attendance-marking-ux
Jan 17, 2022
Merged
feat(UX): Option to exclude holidays while marking monthly attendance #29185
ruchamahabal
merged 2 commits into
frappe:develop
from
ruchamahabal:attendance-marking-ux
Jan 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
changed the title
feat(UX): Ability to exclude holidays while marking monthly attendance
feat(UX): Option to exclude holidays while marking monthly attendance
Jan 7, 2022
Codecov Report
@@ Coverage Diff @@
## develop #29185 +/- ##
===========================================
- Coverage 57.96% 57.79% -0.17%
===========================================
Files 1110 1110
Lines 68083 68087 +4
===========================================
- Hits 39466 39354 -112
- Misses 28617 28733 +116
|
ruchamahabal
added
needs-tests
This PR needs automated unit-tests.
and removed
needs-tests
This PR needs automated unit-tests.
labels
Jan 12, 2022
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
KrithiRamani
pushed a commit
to KrithiRamani/erpnext
that referenced
this pull request
Mar 14, 2022
… (backport frappe#29185) (frappe#29321) (cherry picked from commit 6aac8de) Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
While marking monthly Attendance in bulk for an employee from the attendance list view, the Attendance checklist includes all the days of the month for which attendance is not marked. The user has to manually uncheck holidays while doing so which is cumbersome.
Fix:
Add an option to Exclude Holidays while marking attendance in bulk.
Docs: https://docs.erpnext.com/docs/v13/user/manual/en/human-resources/attendance/edit?wiki_page_patch=8cd07a867b