Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken UOM auto complete #29242

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Jan 11, 2022

closes: #28749

This is broken on newly created sites because during setup we do db_insert which converts None to 0 and inserts it, so DB's column default doesn't work. 🤦

Added patch to toggle on all sites created after the PR was merged.

PS: Only affects newly created sites.

caused by combination of #27993 and #25606

All new recent sites seem to have all UOMs as disabled by default. The
desired behaviour is exact opposite of this.
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #29242 (94b8c4d) into develop (c45042c) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29242      +/-   ##
===========================================
- Coverage    57.97%   57.83%   -0.15%     
===========================================
  Files         1110     1110              
  Lines        67990    67991       +1     
===========================================
- Hits         39419    39322      -97     
- Misses       28571    28669      +98     
Impacted Files Coverage Δ
.../setup/setup_wizard/operations/install_fixtures.py 92.99% <ø> (ø)
...unts/report/purchase_register/purchase_register.py 32.19% <0.00%> (-45.90%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 58.00% <0.00%> (-20.00%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
...ctype/woocommerce_settings/woocommerce_settings.py 80.76% <0.00%> (-3.85%) ⬇️
...eport/item_variant_details/item_variant_details.py 84.33% <0.00%> (-3.62%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 85.23% <0.00%> (-2.69%) ⬇️
...xt/stock/report/stock_analytics/stock_analytics.py 91.08% <0.00%> (-1.99%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 91.37% <0.00%> (-1.73%) ⬇️
... and 23 more

@ankush ankush added backport version-13-hotfix Skip Manual Testing The changes in this PR does not require manual testing labels Jan 11, 2022
@ankush ankush merged commit f811956 into frappe:develop Jan 11, 2022
@ankush ankush deleted the uom_autocomplete_broken branch January 11, 2022 12:19
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UOM auto complete broken
1 participant