-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LIFO valuation #29296
Merged
Merged
feat: LIFO valuation #29296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29296 +/- ##
===========================================
+ Coverage 48.82% 58.43% +9.60%
===========================================
Files 1107 1096 -11
Lines 69162 68814 -348
===========================================
+ Hits 33768 40209 +6441
+ Misses 35394 28605 -6789
|
ankush
commented
Jan 15, 2022
ankush
force-pushed
the
lifo_valuation
branch
from
January 17, 2022 06:23
0ef7869
to
37f964a
Compare
gavindsouza
reviewed
Feb 2, 2022
ankush
commented
Feb 2, 2022
Re-use same logic for computing incoming rate.
Co-authored-by: gavin <gavin18d@gmail.com>
ankush
force-pushed
the
lifo_valuation
branch
from
February 6, 2022 14:42
db49522
to
f089d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to FIFO valuation except when consuming last received material is consumed first.
https://www.investopedia.com/articles/02/060502.asp
my first feature in ERPNext
todo:
To test: