Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional doctypes access for ESS user #29317

Merged
merged 5 commits into from
Jan 26, 2022

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Jan 17, 2022

Additional doctypes access for ESS User

no-docs

Depends on: frappe/frappe#15707
Not adding tests, it's just a default configuration change

To test:

Check if a user with Employee Self Service role is able to access these doctypes with relevant permissions:

# masters
'Holiday List': ['read'],
'Employee': ['read', 'write'],
# payroll
'Salary Slip': ['read'],
'Employee Benefit Application': ['read', 'write', 'create', 'delete'],
# expenses
'Expense Claim': ['read', 'write', 'create', 'delete'],
'Employee Advance': ['read', 'write', 'create', 'delete'],
# leave and attendance
'Leave Application': ['read', 'write', 'create', 'delete'],
'Attendance Request': ['read', 'write', 'create', 'delete'],
'Compensatory Leave Request': ['read', 'write', 'create', 'delete'],
# tax
'Employee Tax Exemption Declaration': ['read', 'write', 'create', 'delete'],
'Employee Tax Exemption Proof Submission': ['read', 'write', 'create', 'delete'],
# projects
'Timesheet': ['read', 'write', 'create', 'delete', 'submit', 'cancel', 'amend'],
# trainings
'Training Program': ['read'],
'Training Feedback': ['read', 'write', 'create', 'delete', 'submit', 'cancel', 'amend'],
# shifts
'Shift Request': ['read', 'write', 'create', 'delete', 'submit', 'cancel', 'amend'],
# misc
'Employee Grievance': ['read', 'write', 'create', 'delete'],
'Employee Referral': ['read', 'write', 'create', 'delete'],
'Travel Request': ['read', 'write', 'create', 'delete']

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jan 17, 2022
@ruchamahabal ruchamahabal removed the needs-tests This PR needs automated unit-tests. label Jan 17, 2022
@ruchamahabal ruchamahabal added this to the v14.0 milestone Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #29317 (1bca83c) into develop (7eab945) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #29317      +/-   ##
===========================================
+ Coverage    58.46%   58.48%   +0.01%     
===========================================
  Files         1091     1091              
  Lines        67881    67881              
===========================================
+ Hits         39689    39698       +9     
+ Misses       28192    28183       -9     
Impacted Files Coverage Δ
erpnext/setup/install.py 0.00% <0.00%> (ø)
...em_wise_sales_register/item_wise_sales_register.py 51.81% <0.00%> (-9.55%) ⬇️
...unts/report/purchase_register/purchase_register.py 71.23% <0.00%> (-8.91%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 75.00% <0.00%> (-3.00%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-2.95%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 89.13% <0.00%> (-2.18%) ⬇️
...t/accounts/report/general_ledger/general_ledger.py 59.59% <0.00%> (-2.03%) ⬇️
...t/accounts/report/sales_register/sales_register.py 71.51% <0.00%> (-1.82%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 88.52% <0.00%> (-1.64%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
... and 19 more

@ruchamahabal ruchamahabal merged commit 6c1c85b into frappe:develop Jan 26, 2022
@ruchamahabal ruchamahabal deleted the ess-access branch January 26, 2022 19:21
@ruchamahabal
Copy link
Member Author

@Mergifyio backport version-14-beta-pre-release

mergify bot pushed a commit that referenced this pull request Jan 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 29, 2022

backport version-14-beta-pre-release

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant