Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: purchase grouped asset #29334

Merged

Conversation

nextchamp-saqib
Copy link
Member

You can now enable this check to not create individual records of assets.

CleanShot 2022-01-18 at 13 10 45

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #29334 (eff1d6b) into develop (f5ed0c8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #29334      +/-   ##
===========================================
+ Coverage    57.87%   57.88%   +0.01%     
===========================================
  Files         1091     1091              
  Lines        67894    67899       +5     
===========================================
+ Hits         39292    39303      +11     
+ Misses       28602    28596       -6     
Impacted Files Coverage Δ
erpnext/controllers/buying_controller.py 87.02% <100.00%> (+0.15%) ⬆️
...unts/report/purchase_register/purchase_register.py 32.19% <0.00%> (-39.05%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 58.00% <0.00%> (-17.00%) ⬇️
...it_and_loss_statement/profit_and_loss_statement.py 71.42% <0.00%> (-3.90%) ⬇️
...vs_serial_no_count/stock_qty_vs_serial_no_count.py 92.85% <0.00%> (-3.58%) ⬇️
erpnext/assets/doctype/asset/depreciation.py 85.23% <0.00%> (-2.69%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.34% <0.00%> (-1.56%) ⬇️
...e/period_closing_voucher/period_closing_voucher.py 88.23% <0.00%> (-1.48%) ⬇️
...cial_statement/consolidated_financial_statement.py 89.77% <0.00%> (-0.64%) ⬇️
...rpnext/stock/report/stock_balance/stock_balance.py 79.16% <0.00%> (-0.60%) ⬇️
... and 21 more

@nextchamp-saqib nextchamp-saqib removed the needs-tests This PR needs automated unit-tests. label Jan 19, 2022
@nextchamp-saqib nextchamp-saqib merged commit 58cc3b3 into frappe:develop Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants