-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to disable Item Tax Template and Tax Category #29349
feat: option to disable Item Tax Template and Tax Category #29349
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #29349 +/- ##
===========================================
- Coverage 58.96% 57.96% -1.00%
===========================================
Files 1108 1110 +2
Lines 69292 68066 -1226
===========================================
- Hits 40856 39454 -1402
- Misses 28436 28612 +176
|
LGTM. Docs for enable/disable seems kinda too much. Isn't it self-explanatory? :P |
@ankush maybe the special case would be interesting to know. Otherwise (or anyways) we'll get complaints that disabled item tax templates can be selected in a transaction. |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Merging this PR. Failing unit tests are unrelated to this PR and failing on other PRs as well |
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
…-29349 feat: option to disable Item Tax Template and Tax Category (backport #29349)
When Item Tax Template or Tax Category become obsolete we need some option to get rid of them. They might have been used in thousand of items and transactions, so deleting them is not possible.
This PR adds the "Disabled" checkbox to Item Tax Template and Tax Category, similar to Sales/Purchase Taxes and Charges Template.
Effect
Item Tax Template
Tax Category
Item
Transaction