Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Splitting group assets #29350

Merged
merged 4 commits into from
Jan 29, 2022
Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Jan 19, 2022

Provision to split assets based on asset quantity

telegram-cloud-photo-size-5-6287417322448728358-y

Splitting an Asset

Asset.Splitting.mp4
  1. Create an Existing Asset with asset qty more than 1
  2. Try splitting the asset based on qty as shown above and see if the amount gets updated proportionally in both the assets

no-docs

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #29350 (4d87465) into develop (452a809) will increase coverage by 0.08%.
The diff coverage is 87.67%.

@@             Coverage Diff             @@
##           develop   #29350      +/-   ##
===========================================
+ Coverage    58.52%   58.61%   +0.08%     
===========================================
  Files         1091     1091              
  Lines        67899    67985      +86     
===========================================
+ Hits         39740    39849     +109     
+ Misses       28159    28136      -23     
Impacted Files Coverage Δ
erpnext/assets/doctype/asset/asset.py 78.88% <87.67%> (+3.26%) ⬆️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 82.92% <0.00%> (-2.44%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (-1.32%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 91.90% <0.00%> (-1.16%) ⬇️
erpnext/controllers/stock_controller.py 89.64% <0.00%> (-1.02%) ⬇️
erpnext/projects/doctype/project/project.py 54.54% <0.00%> (-0.70%) ⬇️
erpnext/selling/doctype/quotation/quotation.py 49.18% <0.00%> (-0.55%) ⬇️
erpnext/hr/utils.py 74.80% <0.00%> (-0.40%) ⬇️
erpnext/stock/stock_ledger.py 85.60% <0.00%> (-0.37%) ⬇️
... and 13 more

@deepeshgarg007 deepeshgarg007 merged commit eba0621 into frappe:develop Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant