Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set title and search fields in HR and Payroll doctypes #29351

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

ruchamahabal
Copy link
Member

No one wants to see just naming series/hashes in their listview and link fields for most of the doctypes. Set title and search fields for HR doctypes for context.

Closes #29190

@ruchamahabal ruchamahabal marked this pull request as draft January 19, 2022 07:14
@ruchamahabal ruchamahabal changed the title chore: set title and search fields in HR doctypes chore: set title and search fields in HR and Payroll doctypes Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #29351 (ef99f5a) into develop (b9f70ed) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #29351      +/-   ##
===========================================
+ Coverage    57.97%   57.99%   +0.01%     
===========================================
  Files         1110     1110              
  Lines        68067    68067              
===========================================
+ Hits         39464    39473       +9     
+ Misses       28603    28594       -9     
Impacted Files Coverage Δ
...em_wise_sales_register/item_wise_sales_register.py 51.81% <0.00%> (-11.37%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.33% <0.00%> (-7.28%) ⬇️
...unts/report/purchase_register/purchase_register.py 73.28% <0.00%> (-6.85%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 75.00% <0.00%> (-3.00%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 92.45% <0.00%> (-1.89%) ⬇️
erpnext/stock/reorder_item.py 75.21% <0.00%> (-1.71%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 55.22% <0.00%> (-1.50%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.36% <0.00%> (-1.29%) ⬇️
...ype/account/chart_of_accounts/chart_of_accounts.py 77.39% <0.00%> (-0.69%) ⬇️
erpnext/hr/utils.py 74.80% <0.00%> (-0.40%) ⬇️
... and 23 more

@ruchamahabal ruchamahabal marked this pull request as ready for review January 19, 2022 08:23
@ruchamahabal ruchamahabal merged commit 5ae44f3 into frappe:develop Jan 19, 2022
@ruchamahabal ruchamahabal deleted the leave-policy-title branch January 19, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Leave Policy renamable
1 participant