refactor!: remove amazon mws integration #29438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
changed the title
|
@s-aga-r we will need to add a patch that removes doctypes from db. Example: #27313 general checklist here: https://frappe.io/handbook/splitting-modules Also remove this patch: https://github.com/frappe/erpnext/blob/develop/erpnext/patches/v12_0/rename_mws_settings_fields.py |
s-aga-r
requested review from
deepeshgarg007,
marination and
nextchamp-saqib
as code owners
ankush
approved these changes
Feb 14, 2022
ankush
added
the
squash
|
@s-aga-r add warning patch on v13. |
ankush
changed the title
s-aga-r
added
refactor
and removed
squash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Amazon MWS Integration from core to ecommerce_integrations