-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typeerror on invoice creation from SO/PO #29560
Merged
nextchamp-saqib
merged 4 commits into
frappe:develop
from
ruthra-kumar:bug_invoice_creation_throws_typeerror
Feb 8, 2022
Merged
fix: typeerror on invoice creation from SO/PO #29560
nextchamp-saqib
merged 4 commits into
frappe:develop
from
ruthra-kumar:bug_invoice_creation_throws_typeerror
Feb 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
requested review from
ankush,
marination and
rohitwaghchaure
as code owners
February 1, 2022 10:47
nextchamp-saqib
approved these changes
Feb 4, 2022
Codecov Report
@@ Coverage Diff @@
## develop #29560 +/- ##
===========================================
+ Coverage 53.59% 59.00% +5.41%
===========================================
Files 1111 1112 +1
Lines 69328 69469 +141
===========================================
+ Hits 37153 40989 +3836
+ Misses 32175 28480 -3695
|
nextchamp-saqib
added
backport version-13-hotfix
and removed
needs-tests
This PR needs automated unit-tests.
labels
Feb 8, 2022
nextchamp-saqib
added a commit
that referenced
this pull request
Feb 8, 2022
…-29560 fix: typeerror on invoice creation from SO/PO (backport #29560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
"TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'" occurs when an invoice is created from SO/PO.
Replication Steps
'Automatically Fetch Payment Terms from Order' is enabled.
SO/PO should have payment term with '0%' invoice portion.
Create-> Sales/Purchase Invoice should throw error
Fix
The payment_schedule object created by auto fetch feature has uninitialised attribute 'payment_amount' which causes this error. It has been fixed in this change.