Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show stock value difference on Stock Ledger report #29607

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Feb 3, 2022

Show stock value difference and sum of stock value difference so it's easy to infer the accounting impact of a particular voucher.

Screenshot 2022-02-03 at 10 52 35 AM

TODO:
don't show totals for all the rows. (requires FW change) deferred, not a small change as it seemed first - https://github.com/frappe/frappe/issues/15866

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 3, 2022
@ankush ankush added backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Feb 3, 2022
@ankush ankush marked this pull request as ready for review February 3, 2022 11:42
@ankush ankush merged commit 04f6426 into frappe:develop Feb 3, 2022
mergify bot pushed a commit that referenced this pull request Feb 3, 2022
ankush added a commit that referenced this pull request Feb 3, 2022
…9621)

(cherry picked from commit 04f6426)

Co-authored-by: Ankush Menat <ankush@frappe.io>
@ankush ankush deleted the show_stock_value_diff branch February 3, 2022 11:59
mergify bot added a commit that referenced this pull request Feb 11, 2022
…9621)

(cherry picked from commit 04f6426)

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit b93d8f8)
@ankush ankush added the Skip Manual Testing The changes in this PR does not require manual testing label Feb 12, 2022
@ankush ankush removed the Skip Manual Testing The changes in this PR does not require manual testing label Mar 9, 2022
KrithiRamani pushed a commit to KrithiRamani/erpnext that referenced this pull request Mar 14, 2022
… (frappe#29621)

(cherry picked from commit 04f6426)

Co-authored-by: Ankush Menat <ankush@frappe.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant