-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove India specific code #29884
Conversation
ffd92f0
to
1db5a16
Compare
3936d8b
to
bb8a618
Compare
bb8a618
to
b90a134
Compare
Reopen when it's time? |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Codecov Report
@@ Coverage Diff @@
## develop #29884 +/- ##
===========================================
+ Coverage 63.64% 64.57% +0.93%
===========================================
Files 986 965 -21
Lines 67882 65161 -2721
===========================================
- Hits 43201 42078 -1123
+ Misses 24681 23083 -1598
|
|
Currently kept as-is
HR Related Code (to be moved to HRMS app)
setup_gratuity_rule_for_india_and_uae
move_tax_slabs_from_payroll_period_to_income_tax_slab
check_is_income_tax_component
Lower Deduction Certificate and related code (to be ported later)
Notes for reviewer
Certain patches have been kept back with code that applied to countries outside India
removed_roles_from_gst_report_non_indian_account
create_gst_payment_entry_fields
Changes in
asset_value_adjustment.py
were not ported because they are redundant. The functionget_depreciation_amount
has been already patched using regional overrides and ported to India Compliance.A test in purchase invoice was changed to create fixtures that have been moved to India Compliance.