Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed validation to check zero qty #30015

Conversation

rohitwaghchaure
Copy link
Collaborator

Steps to replicate the issue

  1. Set backflush bashed on as "Material Transferred for Subcontract" in the buying settings
  2. Create the subcontracted Purchase Order
  3. Transfer extra materials in batches
  4. While making purchase receipt, update the Consumed Qty of one raw material to zero
  5. Try to save the purchase receipt
  6. You will get the error that "the consumed qty cannot be zero for the item XYZ"

Why user wants to keep the qty as Zero?
User has transferred extra materials which supplier has not consumed and user wants to return non consumed materials back to the their store warehouse

Issue
Screenshot 2022-02-28 at 2 22 43 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 28, 2022
@rohitwaghchaure rohitwaghchaure removed the needs-tests This PR needs automated unit-tests. label Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #30015 (39d3f20) into develop (96e87fe) will decrease coverage by 4.15%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #30015      +/-   ##
===========================================
- Coverage    59.48%   55.33%   -4.16%     
===========================================
  Files         1109     1084      -25     
  Lines        69188    68458     -730     
===========================================
- Hits         41157    37879    -3278     
- Misses       28031    30579    +2548     
Impacted Files Coverage Δ
erpnext/controllers/subcontracting.py 91.98% <ø> (+0.22%) ⬆️
...rpnext/hr/doctype/grievance_type/grievance_type.py 0.00% <0.00%> (-100.00%) ⬇️
...pnext/loan_management/doctype/unpledge/unpledge.py 0.00% <0.00%> (-100.00%) ⬇️
...next/accounts/doctype/dunning_type/dunning_type.py 0.00% <0.00%> (-100.00%) ⬇️
...next/hr/doctype/vehicle_service/vehicle_service.py 0.00% <0.00%> (-100.00%) ⬇️
.../accounts/doctype/budget_account/budget_account.py 0.00% <0.00%> (-100.00%) ⬇️
...ounts/doctype/cash_flow_mapper/cash_flow_mapper.py 0.00% <0.00%> (-100.00%) ⬇️
...nts/doctype/allowed_dimension/allowed_dimension.py 0.00% <0.00%> (-100.00%) ⬇️
...nts/doctype/bank_account_type/bank_account_type.py 0.00% <0.00%> (-100.00%) ⬇️
...doctype/dunning_letter_text/dunning_letter_text.py 0.00% <0.00%> (-100.00%) ⬇️
... and 179 more

@rohitwaghchaure rohitwaghchaure merged commit bbfff1b into frappe:develop Feb 28, 2022
@rohitwaghchaure
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

backport version-13-hotfix

✅ Backports have been created

rohitwaghchaure added a commit that referenced this pull request Mar 1, 2022
…-30015

refactor: removed validation to check zero qty (backport #30015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant