feat: Create single PL/DN from several SO. #30238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrithiRamani
requested review from
marination,
rohitwaghchaure and
ankush
as code owners
KrithiRamani
requested review from
nextchamp-saqib and
deepeshgarg007
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #30238 +/- ##
===========================================
+ Coverage 60.38% 60.56% +0.17%
===========================================
Files 1084 1084
Lines 68613 68670 +57
===========================================
+ Hits 41431 41589 +158
+ Misses 27182 27081 -101
|
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
ankush
pushed a commit
that referenced
this pull request
Mar 17, 2022
* feat: Create single PL/DN from several SO. New PR from latest develop to avoid rebase (cherry picked from commit 61eb9b6) * to enable selection of SO irrespective of customer,removed validation for customer (cherry picked from commit 466df6b) * fixed spacings (cherry picked from commit f33a725) * added new field - Picked Qty, in Sales Order Item (cherry picked from commit a68213d) * Added new field in SO - % Picked (cherry picked from commit 9f7fee7) * removed semicolon for break statement (cherry picked from commit e970616) * as per review comments - changed for loop (cherry picked from commit 0211f27) * corrected spacing (cherry picked from commit a12895e) Co-authored-by: Krithi Ramani <krithi.ramani@gmail.com>
ankush
reviewed
Mar 17, 2022
| if location.sales_order_item: | ||
| self.update_so(location.sales_order_item,0,location.item_code) | ||
|
|
||
| def update_so(self,so_item,picked_qty,item_code): |
There was a problem hiding this comment.
missing whitespace? Multiple instances of this. 😅
for future reference: https://peps.python.org/pep-0008/
This was referenced Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR from latest develop to avoid rebase (old PR #29065 )
Documentation Updates:
https://docs.erpnext.com/docs/v13/user/manual/en/stock/delivery-note/edit?wiki_page_patch=eb709e059f
https://docs.erpnext.com/docs/v13/user/manual/en/stock/pick-list/edit?wiki_page_patch=24f2742f11
Test Cases:
Customer is not mandatory in PL
Allow selection of multiple SO from several customers
Do not edit Picked Qty in PL. Submit the PL
Let qty = 10. Enter 5 as picked qty and submit
On submit of PL
Create PL for an SO where
Create PL from multiple SO by clicking on ‘Get Items’
Create PL by adding items manually(not from SO). Then select an SO also. PL now has both items from SO and those not from SO