Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change "is_subcontracted" field type from "Select" to "Check" #30528

Merged
merged 5 commits into from
Apr 4, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Mar 31, 2022

Change the "is_subcontracted" field type from "Select" to "Check" in Purchase Order, Purchase Receipt, Purchase Invoice, Supplier Quotation.

@ankush ankush changed the title chore: change "is_subcontracted" field type from "Select" to "Check" refactor!: change "is_subcontracted" field type from "Select" to "Check" Mar 31, 2022
@s-aga-r s-aga-r force-pushed the is-subcontracted-fieldtype branch 2 times, most recently from 57e0e9a to 2cc59f7 Compare March 31, 2022 17:10
erpnext/controllers/buying_controller.py Outdated Show resolved Hide resolved
erpnext/patches.txt Outdated Show resolved Hide resolved
erpnext/patches/v14_0/change_is_subcontracted_fieldtype.py Outdated Show resolved Hide resolved
erpnext/stock/doctype/bin/bin.py Outdated Show resolved Hide resolved
@s-aga-r s-aga-r force-pushed the is-subcontracted-fieldtype branch from 3428481 to eb0eb88 Compare April 1, 2022 07:53
@s-aga-r s-aga-r force-pushed the is-subcontracted-fieldtype branch from dce0588 to 01c6491 Compare April 1, 2022 10:22
@ankush ankush added this to the v14.0 milestone Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #30528 (1717468) into develop (02dab02) will increase coverage by 0.04%.
The diff coverage is 86.04%.

❗ Current head 1717468 differs from pull request most recent head cf5f37e. Consider uploading reports for the commit cf5f37e to get more accurate results

@@             Coverage Diff             @@
##           develop   #30528      +/-   ##
===========================================
+ Coverage    60.91%   60.96%   +0.04%     
===========================================
  Files         1083     1083              
  Lines        69112    69122      +10     
===========================================
+ Hits         42103    42141      +38     
+ Misses       27009    26981      -28     
Impacted Files Coverage Δ
...ontract_order_summary/subcontract_order_summary.py 0.00% <ø> (ø)
...o_be_received/subcontracted_item_to_be_received.py 96.00% <ø> (ø)
...d/subcontracted_raw_materials_to_be_transferred.py 95.45% <ø> (ø)
...cturing/doctype/production_plan/production_plan.py 75.00% <0.00%> (ø)
erpnext/stock/doctype/bin/bin.py 97.87% <ø> (ø)
erpnext/templates/pages/home.py 69.23% <33.33%> (ø)
erpnext/accounts/general_ledger.py 94.34% <85.00%> (-0.59%) ⬇️
...xt/buying/doctype/purchase_order/purchase_order.py 79.17% <100.00%> (ø)
erpnext/controllers/accounts_controller.py 85.27% <100.00%> (+0.23%) ⬆️
erpnext/controllers/buying_controller.py 87.23% <100.00%> (+0.17%) ⬆️
... and 53 more

@s-aga-r s-aga-r requested a review from ankush April 1, 2022 10:45
@s-aga-r s-aga-r force-pushed the is-subcontracted-fieldtype branch 4 times, most recently from b67394d to 01c6491 Compare April 4, 2022 06:29
@ankush ankush force-pushed the is-subcontracted-fieldtype branch from 9a345d1 to cf5f37e Compare April 4, 2022 06:45
@ankush ankush merged commit 52eb0a9 into frappe:develop Apr 4, 2022
Copy link
Contributor

@casesolved-co-uk casesolved-co-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't mean to change this file. This will have introduced a bug.
erpnext/accounts/report/tax_detail/test_tax_detail.json

@s-aga-r
Copy link
Contributor Author

s-aga-r commented Nov 12, 2022

You didn't mean to change this file. This will have introduced a bug. erpnext/accounts/report/tax_detail/test_tax_detail.json

@casesolved-co-uk Can you create a GitHub issue for the same with a description of the bug?

@s-aga-r s-aga-r deleted the is-subcontracted-fieldtype branch April 15, 2023 10:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants