Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle multiple item transfer in separate SEs against WO #30674

Merged
merged 4 commits into from
Apr 11, 2022

Conversation

marination
Copy link
Collaborator

@marination marination commented Apr 11, 2022

Closes #26535 and more.

Issue:

  • Consider FG with Raw Materials Item A and B.

  • FG : RM 1 : RM2 = 1 : 1 : 1

  • Backflush Raw Materials Based On = Material Transferred for Manufacture

  • Make a WO for 1 Qty.

  • Transfer Item A only. Material Transferred for Manufacturing in WO = 1

  • Now there's no way to transfer Item B, since WO assumes transfer is done due to Material Transferred for Manufacturing

  • Screen.Recording.2022-04-11.at.3.49.10.PM.mov

Fix:

  • Check for pending qty in child items to show/hide "Start" button, even if Material Transferred for Manufacturing meets requirements

  • If no qty needed to transfer (FG qty is fulfilled), but RM qty pending: map pending in SE with For Quantity = 0

  • Screen.Recording.2022-04-11.at.3.47.05.PM.mov

For partial transfers of larger qty, users will have to edit "For Quantity" and set it to 0 for now if they don't want to increase Material Transferred for Manufacturing. Thinking of a way to improve this UX

- Check for pending qty in child items to show/hide "Start" button
- If no qty needed to transfer (FG qty is fulfilled), but RM qty pending: map pending in SE with For Quantity = 0
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 11, 2022
- Added test and acceptance of 0 as For Quantity in test helper
@marination marination removed the needs-tests This PR needs automated unit-tests. label Apr 11, 2022
@marination marination marked this pull request as ready for review April 11, 2022 11:19
@marination marination merged commit 014298a into frappe:develop Apr 11, 2022
marination added a commit that referenced this pull request Apr 11, 2022
…-30674

fix: Handle multiple item transfer in separate SEs against WO (backport #30674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stock entry issue while doing material transfer against work order
1 participant