-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: minor enhancements in Employee Promotion #30780
Merged
ruchamahabal
merged 10 commits into
frappe:develop
from
ruchamahabal:promotion-enhancements
Apr 22, 2022
Merged
feat: minor enhancements in Employee Promotion #30780
ruchamahabal
merged 10 commits into
frappe:develop
from
ruchamahabal:promotion-enhancements
Apr 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
promotion-enhancements
branch
from
April 22, 2022 11:55
b2528b5
to
788e0a1
Compare
Codecov Report
@@ Coverage Diff @@
## develop #30780 +/- ##
===========================================
+ Coverage 61.46% 61.65% +0.18%
===========================================
Files 1080 1079 -1
Lines 69537 69542 +5
===========================================
+ Hits 42741 42873 +132
+ Misses 26796 26669 -127
|
ruchamahabal
requested review from
deepeshgarg007,
nextchamp-saqib,
marination and
ankush
as code owners
April 22, 2022 14:14
ruchamahabal
force-pushed
the
promotion-enhancements
branch
from
April 22, 2022 14:50
3a58551
to
9d15808
Compare
ruchamahabal
removed request for
ankush,
nextchamp-saqib,
marination,
pateljannat and
deepeshgarg007
April 22, 2022 16:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
promotion-before.mp4
After
employee-promotion-after.mp4
Also removing Employee Transfer Property doctype which does nothing:
Docs:
P.S.: This also updates Employee Transfer because it uses the same property updater.