Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(india): e-invoice generation for registered composition gst category type #30814

Merged
merged 2 commits into from
May 2, 2022
Merged

fix(india): e-invoice generation for registered composition gst category type #30814

merged 2 commits into from
May 2, 2022

Conversation

maharshivpatel
Copy link
Contributor

Sales Invoice for Buyer with GST Category "Registered Composition" is also B2B Transaction and e-invoice generation is mandatory (required) in this case.

I have made the necessary changes to enable e-invoice generation for the "Registered Composition" gst_category type and show the IRN field for the same.

This Closes #30813.

@maharshivpatel
fix(india): e-invoice generation is required for registered compositi…
bada35e 
…on gst category type

Sales Invoice for Buyer with GST Category "Registered Composition" is also B2B Transaction and e-invoice generation is mandatory (required) in this case.
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #30814 (bada35e) into develop (dcc2243) will increase coverage by 0.12%.
The diff coverage is 50.00%.

❗ Current head bada35e differs from pull request most recent head f5c8f75. Consider uploading reports for the commit f5c8f75 to get more accurate results

@@             Coverage Diff             @@
##           develop   #30814      +/-   ##
===========================================
+ Coverage    61.44%   61.57%   +0.12%     
===========================================
  Files         1079     1079              
  Lines        69613    69613              
===========================================
+ Hits         42776    42862      +86     
+ Misses       26837    26751      -86
Impacted Files Coverage Δ
erpnext/regional/india/setup.py 94.24% <ø> (ø)
erpnext/regional/india/e_invoice/utils.py 42.25% <50.00%> (ø)
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 76.95% <0.00%> (-8.24%) ⬇️
...t/accounts/report/sales_register/sales_register.py 71.34% <0.00%> (-6.44%) ⬇️
erpnext/accounts/party.py 78.09% <0.00%> (-4.33%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 61.08% <0.00%> (-0.91%) ⬇️
erpnext/stock/reorder_item.py 75.21% <0.00%> (-0.86%) ⬇️
erpnext/stock/report/stock_ageing/stock_ageing.py 95.19% <0.00%> (-0.49%) ⬇️
... and 29 more

@nextchamp-saqib nextchamp-saqib removed the needs-tests This PR needs automated unit-tests. label May 2, 2022
@nextchamp-saqib nextchamp-saqib changed the title fix(india): e-invoice generation is required for registered composition gst category type fix(india): e-invoice generation for registered composition gst category type May 2, 2022
@nextchamp-saqib nextchamp-saqib merged commit 80a13c3 into frappe:develop May 2, 2022
mergify bot pushed a commit that referenced this pull request May 2, 2022
@maharshivpatel @mergify
fix(india): e-invoice generation for registered composition gst categ…
e91c459 
…ory type (#30814)

(cherry picked from commit 80a13c3)
@mergify mergify bot mentioned this pull request May 2, 2022
Merged
nextchamp-saqib pushed a commit that referenced this pull request May 2, 2022
@mergify
fix(india): e-invoice generation for registered composition gst categ…
246869d 
…ory type (#30814) (#30877)
frappe-pr-bot pushed a commit that referenced this pull request May 3, 2022
@frappe-bot
chore(release): Bumped to Version 13.28.0
53024be 
# [13.28.0](v13.27.1...v13.28.0) (2022-05-03)

### Bug Fixes

* Consistent accounting dimensions across Sales and Purchase docs ([5df5058](5df5058))
* convert default_item_manufacturer to link field ([#30835](#30835)) ([#30866](#30866)) ([37fad7e](37fad7e))
* Cost center filter on payment reconciliation ([22e7f03](22e7f03))
* filters not working in Shift Assignment Calendar view ([#30822](#30822)) ([3cdbb65](3cdbb65))
* Ignore custom field validation while setup ([ee54bf7](ee54bf7))
* **india:** e-invoice generation for registered composition gst category type ([#30814](#30814)) ([#30877](#30877)) ([246869d](246869d))
* Multi currency opening invoices ([2e62d51](2e62d51))
* payment days calculation for employees joining/leaving mid-month ([#30863](#30863)) ([#30883](#30883)) ([a1b0813](a1b0813))
* Period Closing Voucher is considering GL entries with is_cancelled=1 ([#30865](#30865)) ([5a5b49b](5a5b49b))
* **pos:** number pad translations ([b01f855](b01f855))
* **pos:** search field doesn't reset on checkout ([edbf551](edbf551))
* Supply type for overseas invoices with payment of tax ([fdcc591](fdcc591))
* supply type for sez invoices with payment of tax ([cf08710](cf08710))
* Use `account_type == 'Stock'` to filter stock accounts ([93482f3](93482f3))
* **UX:** misleading stock entry lables ([#30870](#30870)) ([#30871](#30871)) ([57b03f0](57b03f0))
* **UX:** record reason for skipping attendance or marking absent for auto attendance ([#30846](#30846)) ([f7bf4a3](f7bf4a3))
* Vat Audit report fixes ([d5319a4](d5319a4))

### Features

* Copy task color from project template (backport [#30857](#30857)) ([#30859](#30859)) ([7ee18e8](7ee18e8))
* support product bundles in picklist (backport [#30762](#30762)) ([#30826](#30826)) ([645ee2d](645ee2d))
rootsec1 added a commit to rootsec1/erpnext that referenced this pull request May 4, 2022
@rootsec1 @deepeshgarg007
@ruthra-kumar @ruchamahabal @rmehta @sersaber @ankush @marination @nextchamp-saqib @maharshivpatel @fproldan
merge1 (#1)
3b7efd6 
* fix: Allow multi-currency opening invoices

* feat: add payment terms status rpr to Selling homepage

* fix: Consistent accounting dimensions across Sales and Purchase docs

* fix: Ignore custom field validation while setup

* chore: Remove domains from Setup

* refactor: Remove education domain from ERPNext

* chore: remove files related to LMS

* chore: clean up hooks

* chore: Remove course links from training doctypes

* chore: Remove references for Assessment Group

* chore: Remove Fees Doctype

* chore: Remove references for Student doctype

* chore: Add patch to delete education doctypes

* chore: Clean up patches

* fix: Multi currency opening invoices

* fix(UX): record reason for skipping attendance or marking absent for auto attendance (frappe#30844)

* fix: Cost center filter on payment reconciliation

* fix(minor): discount accounting patch

* fix(minor): fix create_accounting_dimensions_in_orders.py

* feat: Copy task color from project template (frappe#30857)

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>

* chore: correct link

* fix: convert default_item_manufacturer to link field (frappe#30835)

* fix(minor): update frappe.error_log to new API (frappe#30864)

* fix(minor): update frappe.error_log to new API

* refactor: changes for updated log_error api

Co-authored-by: Ankush Menat <ankush@frappe.io>

* fix(UX): misleading stock entry lables (frappe#30870)

* fix(UX): misleading stock entry lables

* chore: field labels

[skip ci]

Co-authored-by: Marica <maricadsouza221197@gmail.com>

Co-authored-by: Marica <maricadsouza221197@gmail.com>

* test: Add test for payment reconciliation

* fix: Vat Audit report fixes

(cherry picked from commit d5319a4)

* fix: Supply type for overseas invoices with payment of tax

* fix: supply type for sez invoices with payment of tax

* fix(india): e-invoice generation for registered composition gst category type (frappe#30814)

* fix: supplier quotation comparission report button

* fix: payment days calculation for employees joining/leaving mid-month (frappe#30863)

* chore: Resolve conflicts

* fix: Ignore loan repayments made from salary slip

(cherry picked from commit b7e1d40)

* fix: show group warehouse in Sales Order (frappe#30891)

* fix: Show linked time sheets in sales invoice dashboard

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: ruthra kumar <ruthra@erpnext.com>
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Co-authored-by: Rushabh Mehta <rmehta@gmail.com>
Co-authored-by: sersaber <93864988+sersaber@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Marica <maricadsouza221197@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: maharshivpatel <39730881+maharshivpatel@users.noreply.github.com>
Co-authored-by: Francisco Roldán <franciscoproldan@gmail.com>
hrwX pushed a commit to hrwX/erpnext that referenced this pull request May 10, 2022
@maharshivpatel @hrwX
fix(india): e-invoice generation for registered composition gst categ…
35cde81 
…ory type (frappe#30814)
deepeshgarg007 pushed a commit to deepeshgarg007/erpnext that referenced this pull request May 13, 2022
@frappe-bot @deepeshgarg007
chore(release): Bumped to Version 13.28.0
8cc2ea0 
# [13.28.0](frappe/erpnext@v13.27.1...v13.28.0) (2022-05-03)

### Bug Fixes

* Consistent accounting dimensions across Sales and Purchase docs ([5df5058](frappe@5df5058))
* convert default_item_manufacturer to link field ([frappe#30835](frappe#30835)) ([frappe#30866](frappe#30866)) ([37fad7e](frappe@37fad7e))
* Cost center filter on payment reconciliation ([22e7f03](frappe@22e7f03))
* filters not working in Shift Assignment Calendar view ([frappe#30822](frappe#30822)) ([3cdbb65](frappe@3cdbb65))
* Ignore custom field validation while setup ([ee54bf7](frappe@ee54bf7))
* **india:** e-invoice generation for registered composition gst category type ([frappe#30814](frappe#30814)) ([frappe#30877](frappe#30877)) ([246869d](frappe@246869d))
* Multi currency opening invoices ([2e62d51](frappe@2e62d51))
* payment days calculation for employees joining/leaving mid-month ([frappe#30863](frappe#30863)) ([frappe#30883](frappe#30883)) ([a1b0813](frappe@a1b0813))
* Period Closing Voucher is considering GL entries with is_cancelled=1 ([frappe#30865](frappe#30865)) ([5a5b49b](frappe@5a5b49b))
* **pos:** number pad translations ([b01f855](frappe@b01f855))
* **pos:** search field doesn't reset on checkout ([edbf551](frappe@edbf551))
* Supply type for overseas invoices with payment of tax ([fdcc591](frappe@fdcc591))
* supply type for sez invoices with payment of tax ([cf08710](frappe@cf08710))
* Use `account_type == 'Stock'` to filter stock accounts ([93482f3](frappe@93482f3))
* **UX:** misleading stock entry lables ([frappe#30870](frappe#30870)) ([frappe#30871](frappe#30871)) ([57b03f0](frappe@57b03f0))
* **UX:** record reason for skipping attendance or marking absent for auto attendance ([frappe#30846](frappe#30846)) ([f7bf4a3](frappe@f7bf4a3))
* Vat Audit report fixes ([d5319a4](frappe@d5319a4))

### Features

* Copy task color from project template (backport [frappe#30857](frappe#30857)) ([frappe#30859](frappe#30859)) ([7ee18e8](frappe@7ee18e8))
* support product bundles in picklist (backport [frappe#30762](frappe#30762)) ([frappe#30826](frappe#30826)) ([645ee2d](frappe@645ee2d))
mergify bot pushed a commit that referenced this pull request May 15, 2022
@frappe-bot @mergify
chore(release): Bumped to Version 13.28.0
b3964ee 
# [13.28.0](v13.27.1...v13.28.0) (2022-05-03)

### Bug Fixes

* Consistent accounting dimensions across Sales and Purchase docs ([5df5058](5df5058))
* convert default_item_manufacturer to link field ([#30835](#30835)) ([#30866](#30866)) ([37fad7e](37fad7e))
* Cost center filter on payment reconciliation ([22e7f03](22e7f03))
* filters not working in Shift Assignment Calendar view ([#30822](#30822)) ([3cdbb65](3cdbb65))
* Ignore custom field validation while setup ([ee54bf7](ee54bf7))
* **india:** e-invoice generation for registered composition gst category type ([#30814](#30814)) ([#30877](#30877)) ([246869d](246869d))
* Multi currency opening invoices ([2e62d51](2e62d51))
* payment days calculation for employees joining/leaving mid-month ([#30863](#30863)) ([#30883](#30883)) ([a1b0813](a1b0813))
* Period Closing Voucher is considering GL entries with is_cancelled=1 ([#30865](#30865)) ([5a5b49b](5a5b49b))
* **pos:** number pad translations ([b01f855](b01f855))
* **pos:** search field doesn't reset on checkout ([edbf551](edbf551))
* Supply type for overseas invoices with payment of tax ([fdcc591](fdcc591))
* supply type for sez invoices with payment of tax ([cf08710](cf08710))
* Use `account_type == 'Stock'` to filter stock accounts ([93482f3](93482f3))
* **UX:** misleading stock entry lables ([#30870](#30870)) ([#30871](#30871)) ([57b03f0](57b03f0))
* **UX:** record reason for skipping attendance or marking absent for auto attendance ([#30846](#30846)) ([f7bf4a3](f7bf4a3))
* Vat Audit report fixes ([d5319a4](d5319a4))

### Features

* Copy task color from project template (backport [#30857](#30857)) ([#30859](#30859)) ([7ee18e8](7ee18e8))
* support product bundles in picklist (backport [#30762](#30762)) ([#30826](#30826)) ([645ee2d](645ee2d))

(cherry picked from commit 8cc2ea0)

# Conflicts:
#	erpnext/__init__.py
hrwX pushed a commit to hrwX/erpnext that referenced this pull request May 20, 2022
@frappe-bot @hrwX
chore(release): Bumped to Version 13.28.0
1f6c962 
# [13.28.0](frappe/erpnext@v13.27.1...v13.28.0) (2022-05-03)

### Bug Fixes

* Consistent accounting dimensions across Sales and Purchase docs ([5df5058](frappe@5df5058))
* convert default_item_manufacturer to link field ([frappe#30835](frappe#30835)) ([frappe#30866](frappe#30866)) ([37fad7e](frappe@37fad7e))
* Cost center filter on payment reconciliation ([22e7f03](frappe@22e7f03))
* filters not working in Shift Assignment Calendar view ([frappe#30822](frappe#30822)) ([3cdbb65](frappe@3cdbb65))
* Ignore custom field validation while setup ([ee54bf7](frappe@ee54bf7))
* **india:** e-invoice generation for registered composition gst category type ([frappe#30814](frappe#30814)) ([frappe#30877](frappe#30877)) ([246869d](frappe@246869d))
* Multi currency opening invoices ([2e62d51](frappe@2e62d51))
* payment days calculation for employees joining/leaving mid-month ([frappe#30863](frappe#30863)) ([frappe#30883](frappe#30883)) ([a1b0813](frappe@a1b0813))
* Period Closing Voucher is considering GL entries with is_cancelled=1 ([frappe#30865](frappe#30865)) ([5a5b49b](frappe@5a5b49b))
* **pos:** number pad translations ([b01f855](frappe@b01f855))
* **pos:** search field doesn't reset on checkout ([edbf551](frappe@edbf551))
* Supply type for overseas invoices with payment of tax ([fdcc591](frappe@fdcc591))
* supply type for sez invoices with payment of tax ([cf08710](frappe@cf08710))
* Use `account_type == 'Stock'` to filter stock accounts ([93482f3](frappe@93482f3))
* **UX:** misleading stock entry lables ([frappe#30870](frappe#30870)) ([frappe#30871](frappe#30871)) ([57b03f0](frappe@57b03f0))
* **UX:** record reason for skipping attendance or marking absent for auto attendance ([frappe#30846](frappe#30846)) ([f7bf4a3](frappe@f7bf4a3))
* Vat Audit report fixes ([d5319a4](frappe@d5319a4))

### Features

* Copy task color from project template (backport [frappe#30857](frappe#30857)) ([frappe#30859](frappe#30859)) ([7ee18e8](frappe@7ee18e8))
* support product bundles in picklist (backport [frappe#30762](frappe#30762)) ([frappe#30826](frappe#30826)) ([645ee2d](frappe@645ee2d))

(cherry picked from commit 8cc2ea0)

# Conflicts:
#	erpnext/__init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextchamp-saqib nextchamp-saqib nextchamp-saqib approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E Invoice generation is required for "Registered Composition" GST Category Type
2 participants
@maharshivpatel @nextchamp-saqib