Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore custom field validation while setup #30815

Merged
merged 2 commits into from
Apr 30, 2022

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 26, 2022

Ignore custom field validations during localization setup

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #30815 (bfd053e) into develop (dafdc9b) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #30815      +/-   ##
===========================================
- Coverage    61.77%   61.69%   -0.09%     
===========================================
  Files         1079     1079              
  Lines        69701    69715      +14     
===========================================
- Hits         43057    43009      -48     
- Misses       26644    26706      +62     
Impacted Files Coverage Δ
...xt/hr/doctype/employee_checkin/employee_checkin.py 94.26% <100.00%> (+0.62%) ⬆️
erpnext/hr/doctype/shift_type/shift_type.py 86.41% <100.00%> (+0.34%) ⬆️
erpnext/regional/united_arab_emirates/setup.py 100.00% <100.00%> (ø)
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 51.58% <0.00%> (-11.77%) ⬇️
...rial_no_valuation/incorrect_serial_no_valuation.py 85.96% <0.00%> (-10.53%) ⬇️
...t/accounts/report/sales_register/sales_register.py 70.76% <0.00%> (-7.02%) ⬇️
...unts/report/purchase_register/purchase_register.py 71.71% <0.00%> (-6.58%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
... and 30 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 54d16de into frappe:develop Apr 30, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 30, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request May 1, 2022
…-30815

fix: Ignore custom field validation while setup (backport #30815)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant