Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove domains from setup wizard #30820

Merged
merged 3 commits into from
May 3, 2022

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 27, 2022

The only visible change to the users will be the below step missing from the setup wizard. After the domain separation from ERPNext this step was obsolete and didn't do much. The domain field in company master has been made data fields so that there is no data loss for the old user migrations

image

@deepeshgarg007 deepeshgarg007 changed the title chore: Remove domains from setup chore: Remove domains from setup wizard May 1, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #30820 (322f0db) into develop (924cf77) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #30820      +/-   ##
===========================================
- Coverage    63.21%   62.80%   -0.42%     
===========================================
  Files          985      983       -2     
  Lines        67119    67059      -60     
===========================================
- Hits         42429    42116     -313     
- Misses       24690    24943     +253     
Impacted Files Coverage Δ
erpnext/hooks.py 100.00% <ø> (ø)
...ext/setup/setup_wizard/operations/company_setup.py 61.22% <ø> (ø)
...xt/setup/setup_wizard/operations/defaults_setup.py 0.00% <ø> (ø)
.../setup/setup_wizard/operations/install_fixtures.py 92.85% <ø> (-0.14%) ⬇️
erpnext/setup/setup_wizard/setup_wizard.py 77.41% <ø> (-2.00%) ⬇️
erpnext/setup/utils.py 95.34% <ø> (+1.80%) ⬆️
erpnext/domains/retail.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/domains/services.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/domains/distribution.py 0.00% <0.00%> (-100.00%) ⬇️
erpnext/domains/manufacturing.py 0.00% <0.00%> (-100.00%) ⬇️
... and 37 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant