-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove education domain from ERPNext #30830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested review from
nextchamp-saqib,
marination,
ankush,
ruchamahabal and
pateljannat
as code owners
April 28, 2022 12:52
ankush
changed the title
refactor: Remove education domain from ERPNext
refactor!: Remove education domain from ERPNext
Apr 28, 2022
Codecov Report
@@ Coverage Diff @@
## develop #30830 +/- ##
===========================================
+ Coverage 61.47% 62.94% +1.46%
===========================================
Files 1079 985 -94
Lines 69715 67115 -2600
===========================================
- Hits 42859 42245 -614
+ Misses 26856 24870 -1986
|
deepeshgarg007
force-pushed
the
education_sepration
branch
from
April 28, 2022 14:25
e355568
to
2ee20d3
Compare
ankush
force-pushed
the
education_sepration
branch
from
May 2, 2022 06:17
eba93bd
to
f25251b
Compare
ankush
reviewed
May 2, 2022
ankush
pushed a commit
that referenced
this pull request
May 5, 2022
hrwX
pushed a commit
to hrwX/erpnext
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New App Repo Link: https://github.com/frappe/education
version-13 depreciation warning: #30861