Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove education domain from ERPNext #30830

Merged
merged 12 commits into from
May 2, 2022

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Apr 27, 2022

New App Repo Link: https://github.com/frappe/education

version-13 depreciation warning: #30861

@deepeshgarg007 deepeshgarg007 marked this pull request as ready for review April 28, 2022 12:52
@ankush ankush added the needs-patch A patch to fix existing data is required label Apr 28, 2022
@ankush ankush changed the title refactor: Remove education domain from ERPNext refactor!: Remove education domain from ERPNext Apr 28, 2022
@ankush ankush self-assigned this Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #30830 (eba93bd) into develop (54d16de) will increase coverage by 1.46%.
The diff coverage is 40.00%.

❗ Current head eba93bd differs from pull request most recent head f0049da. Consider uploading reports for the commit f0049da to get more accurate results

@@             Coverage Diff             @@
##           develop   #30830      +/-   ##
===========================================
+ Coverage    61.47%   62.94%   +1.46%     
===========================================
  Files         1079      985      -94     
  Lines        69715    67115    -2600     
===========================================
- Hits         42859    42245     -614     
+ Misses       26856    24870    -1986     
Impacted Files Coverage Δ
...t/accounts/report/general_ledger/general_ledger.py 67.91% <ø> (+0.68%) ⬆️
...trial_balance_for_party/trial_balance_for_party.py 0.00% <ø> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 68.84% <40.00%> (+0.26%) ⬆️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
erpnext/hr/doctype/job_applicant/job_applicant.py 63.93% <0.00%> (-3.28%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 66.21% <0.00%> (-2.71%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 89.13% <0.00%> (-2.18%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 55.22% <0.00%> (-1.50%) ⬇️
erpnext/portal/utils.py 27.69% <0.00%> (-1.30%) ⬇️
erpnext/hr/utils.py 77.73% <0.00%> (-0.76%) ⬇️
... and 61 more

@ankush ankush removed the needs-patch A patch to fix existing data is required label Apr 29, 2022
@ankush ankush merged commit bdd55f0 into frappe:develop May 2, 2022
ankush pushed a commit that referenced this pull request May 5, 2022
hrwX pushed a commit to hrwX/erpnext that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants