Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove website from bank account #30900

Merged
merged 1 commit into from
May 6, 2022

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented May 4, 2022

Do bank accounts have websites somewhere in the world? 😕

Or is this used to link to a specific account view in online banking? Maybe "website" is not the best name in this case...

Docs: https://docs.erpnext.com/docs/v13/user/manual/en/accounts/bank-account/edit?wiki_page_patch=c8080abb8a

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #30900 (f1b8a96) into develop (564f5b2) will increase coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #30900      +/-   ##
===========================================
+ Coverage    62.80%   63.01%   +0.21%     
===========================================
  Files          983      983              
  Lines        67062    67062              
===========================================
+ Hits         42115    42262     +147     
+ Misses       24947    24800     -147     
Impacted Files Coverage Δ
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 80.24% <0.00%> (-4.94%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 56.71% <0.00%> (-1.50%) ⬇️
erpnext/controllers/sales_and_purchase_return.py 85.07% <0.00%> (-0.75%) ⬇️
...xt/e_commerce/doctype/website_item/website_item.py 47.73% <0.00%> (-0.42%) ⬇️
erpnext/projects/doctype/project/project.py 53.24% <0.00%> (-0.33%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 90.90% <0.00%> (ø)
... and 20 more

@deepeshgarg007 deepeshgarg007 merged commit cf4128e into frappe:develop May 6, 2022
@barredterra barredterra deleted the bank-account-website branch May 6, 2022 12:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants