Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to use formatting for the field to_discuss in opportunity #30938

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue
The users are receiving emails regarding their upcoming follow-ups on Opportunities.
But the email does not mention the exact Opportunity ID for the follow-up making it a very tedious task for the user to track and identify the exact opportunity.

Solution

Formatting on the field to discuss

image

@rohitwaghchaure
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented May 9, 2022

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@rohitwaghchaure rohitwaghchaure force-pushed the formatting-for-to-discuss-field branch 7 times, most recently from b27ab1e to e964616 Compare May 9, 2022 16:09
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #30938 (3f41cb7) into develop (f92bc4d) will increase coverage by 0.03%.
The diff coverage is 73.33%.

@@             Coverage Diff             @@
##           develop   #30938      +/-   ##
===========================================
+ Coverage    62.91%   62.94%   +0.03%     
===========================================
  Files          983      983              
  Lines        67067    67070       +3     
===========================================
+ Hits         42193    42219      +26     
+ Misses       24874    24851      -23     
Impacted Files Coverage Δ
erpnext/crm/doctype/opportunity/opportunity.py 69.76% <71.42%> (+0.46%) ⬆️
...d_supplies/hsn_wise_summary_of_outward_supplies.py 72.46% <75.00%> (+0.20%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
erpnext/hr/doctype/job_offer/job_offer.py 82.92% <0.00%> (-4.88%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 64.12% <0.00%> (-2.30%) ⬇️
erpnext/stock/doctype/batch/batch.py 82.80% <0.00%> (-0.64%) ⬇️
erpnext/hr/doctype/expense_claim/expense_claim.py 82.41% <0.00%> (-0.51%) ⬇️
erpnext/controllers/accounts_controller.py 85.34% <0.00%> (-0.24%) ⬇️
... and 23 more

@mergify
Copy link
Contributor

mergify bot commented May 10, 2022

backport version-13-hotfix

✅ Backports have been created

rohitwaghchaure added a commit that referenced this pull request May 11, 2022
…-30938

fix: allow to use formatting for the field to_discuss in opportunity (backport #30938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants