Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto accrue loan interest for backdated term loans #31127

Merged
merged 1 commit into from
May 31, 2022

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented May 25, 2022

Loan Interest has to be accrued even for 0 interest loans for the loan amount to show up in Salary Slip. Loan Interest Accrual is a background job that runs at the end of the day, there are cases where users create a loan and directly try to make a salary slip but the loan amount doesn't show up since it's not accrued yet.

To resolve this confusion added a provision to auto accrue loans for such scenarios

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #31127 (96d8b1e) into develop (39fad39) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #31127      +/-   ##
===========================================
+ Coverage    62.97%   63.07%   +0.10%     
===========================================
  Files          984      986       +2     
  Lines        67186    67376     +190     
===========================================
+ Hits         42311    42500     +189     
- Misses       24875    24876       +1     
Impacted Files Coverage Δ
erpnext/loan_management/doctype/loan/loan.py 68.49% <100.00%> (+0.54%) ⬆️
erpnext/payroll/doctype/salary_slip/salary_slip.py 86.12% <100.00%> (-0.15%) ⬇️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
...t/accounts/report/sales_register/sales_register.py 71.92% <0.00%> (-5.85%) ⬇️
...pnext/accounts/report/gross_profit/gross_profit.py 80.24% <0.00%> (-4.94%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 86.04% <0.00%> (-3.49%) ⬇️
... and 60 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@deepeshgarg007 deepeshgarg007 merged commit f07246a into frappe:develop May 31, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented May 31, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request May 31, 2022
…-31127

feat: Auto accrue loan interest for backdated term loans (backport #31127)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant