-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrating data from GL to payment ledger using raw SQL #31182
Merged
deepeshgarg007
merged 2 commits into
frappe:develop
from
ruthra-kumar:migrate_gl_to_payment_ledger_using_sql
Jun 10, 2022
Merged
refactor: migrating data from GL to payment ledger using raw SQL #31182
deepeshgarg007
merged 2 commits into
frappe:develop
from
ruthra-kumar:migrate_gl_to_payment_ledger_using_sql
Jun 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
requested review from
deepeshgarg007,
nextchamp-saqib,
marination and
ankush
as code owners
May 30, 2022 13:45
ruthra-kumar
changed the title
refactor: migration data from GL to payment ledger using raw SQL
refactor: migrating data from GL to payment ledger using raw SQL
May 30, 2022
ruthra-kumar
requested review from
nabinhait
and removed request for
ankush and
marination
May 30, 2022 13:47
Codecov Report
@@ Coverage Diff @@
## develop #31182 +/- ##
===========================================
+ Coverage 63.04% 63.47% +0.42%
===========================================
Files 986 988 +2
Lines 67343 67605 +262
===========================================
+ Hits 42457 42909 +452
+ Misses 24886 24696 -190
|
ruthra-kumar
force-pushed
the
migrate_gl_to_payment_ledger_using_sql
branch
2 times, most recently
from
June 6, 2022 07:16
29cdec7
to
8848548
Compare
ruthra-kumar
force-pushed
the
migrate_gl_to_payment_ledger_using_sql
branch
from
June 8, 2022 12:07
8848548
to
6c9004b
Compare
nabinhait
requested changes
Jun 10, 2022
ruthra-kumar
force-pushed
the
migrate_gl_to_payment_ledger_using_sql
branch
from
June 10, 2022 07:48
6c9004b
to
e2c5243
Compare
ankush
reviewed
Jun 15, 2022
ankush
reviewed
Jul 7, 2022
# split data into chunks | ||
chunk_size = 1000 | ||
try: | ||
for i in range(0, len(gl_entries), chunk_size): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
framework has (undocumented) util for this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the relatively large amount of data in GL Entry, the original patch to migrate data from GL Entry to payment ledger may face performance issues. Hence the patch file has been modified to use raw sql to perform insertion directly into Payment Ledger table.
Changes in PR: