-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: version-14 beta release #31268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: per_billed for return DN * chore: move patch from v14 to v13
- Remove `set_missing_values` from mapper util function since a lot of item data is set after this function is run - `split_batch` can skip `set_missing_values` since no warehouses are set on mapping and relies on user input
Current design of picklist doc doesn't have "picked serial no" so it doesn't make much sense to scan it. Instead it should increment qty only. Might add this in future after fixing UX problems
There was separate function for batch row which frequently didn't receive all the love main function received like: 1. empty row reuse 2. max qty validation Hence it makes sense to combine these in one fat function
we transpile to es2017, so allow use of es2020
feat(stock): Proposed Pick List Scan
fix: Set actual qty and basic rate in SE on warehouse triggers (`get_warehouse_details`)
fix: stock analytics report shows incorrect data there's no stock movement in a period
(cherry picked from commit b14a7b8)
fix: Failing accounting dimension patch (backport #30982)
…y_account_currency_check
if you edit "margin_rate_or_amount" after saving DN then based on selected margin the rate gets updated which isn't valuation rate.
fix(accounts): minor fixes & validations
fix(patch): avoid checking for qty field if it doesnt exits
Adding Link to Opportunity Following the process of Opportunity to Quotation I added a section and link field to Opportunity for a backlink when using "create"-> Request for Quotation from Opportunity.
added Link to Dashboard added backlink to Request for Quotation in the Quotation dashboard for transparency and ease of navigation.
feat: request_for_quotation - show supplier name
fix: German translations for Employee doctype
* fix: Item rate reset on changing posting date * chore: Remove debugger
…report fix: incorrect billed_qty in sales order analysis report when multiple delivery notes for item
fix(Sales Register): incorrect query with dimensions
voucher_wise_stock_value contains tuples and the condition was looking for string, so it's never triggered. Caused by #24200
…l_entries fix: Reverse provisional entries on Purchase Invoice cancel
…sure fix: Close unsecured terms loans
fix: purchase invoice standalone return GLEs
deepeshgarg007
requested review from
gavindsouza,
ankush,
nextchamp-saqib,
marination,
rohitwaghchaure,
ruchamahabal and
pateljannat
as code owners
June 7, 2022 10:46
Codecov Report
@@ Coverage Diff @@
## version-14-beta #31268 +/- ##
===================================================
+ Coverage 61.03% 63.58% +2.55%
===================================================
Files 1082 986 -96
Lines 68690 67456 -1234
===================================================
+ Hits 41924 42895 +971
+ Misses 26766 24561 -2205
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.