Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(India): Incorrect taxable in GSTR-3B report #31294

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

deepeshgarg007
Copy link
Member

Taxable value for invoice having the same item repeated multiple times was not getting reported correctly

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #31294 (50aafdb) into develop (25f9d58) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #31294      +/-   ##
===========================================
- Coverage    63.59%   63.48%   -0.12%     
===========================================
  Files          986      986              
  Lines        67456    67456              
===========================================
- Hits         42902    42826      -76     
- Misses       24554    24630      +76     
Impacted Files Coverage Δ
.../regional/doctype/gstr_3b_report/gstr_3b_report.py 77.91% <100.00%> (-0.09%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
erpnext/accounts/doctype/bank/bank.py 71.42% <0.00%> (-14.29%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 51.36% <0.00%> (-9.55%) ⬇️
...enefit_application/employee_benefit_application.py 64.49% <0.00%> (-8.29%) ⬇️
...unts/report/purchase_register/purchase_register.py 71.71% <0.00%> (-5.27%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 74.25% <0.00%> (-2.98%) ⬇️
... and 29 more

@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jun 10, 2022
…-31294

fix(India): Incorrect taxable in GSTR-3B report (backport #31294)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant