Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(India): Incorrect taxable in GSTR-3B report (backport #31294) #31310

Merged
merged 2 commits into from
Jun 10, 2022
Merged

fix(India): Incorrect taxable in GSTR-3B report (backport #31294) #31310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5d2c59
fix(India): Incorrect taxable in GSTR-3B report
deepeshgarg007 Jun 9, 2022
176a672
chore: cleanup
deepeshgarg007 Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions erpnext/regional/doctype/gstr_3b_report/gstr_3b_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,10 @@ def get_outward_items(self, doctype):
)

for d in item_details:
if d.item_code not in self.invoice_items.get(d.parent, {}):
self.invoice_items.setdefault(d.parent, {}).setdefault(d.item_code, 0.0)
self.invoice_items[d.parent][d.item_code] += d.get("taxable_value", 0) or d.get(
"base_net_amount", 0
)
self.invoice_items.setdefault(d.parent, {}).setdefault(d.item_code, 0.0)
self.invoice_items[d.parent][d.item_code] += d.get("taxable_value", 0) or d.get(
"base_net_amount", 0
)

if d.is_nil_exempt and d.item_code not in self.is_nil_exempt:
self.is_nil_exempt.append(d.item_code)
Expand Down Expand Up @@ -336,7 +335,6 @@ def get_outward_tax_details(self, doctype):

def set_outward_taxable_supplies(self):
inter_state_supply_details = {}

for inv, items_based_on_rate in self.items_based_on_tax_rate.items():
gst_category = self.invoice_detail_map.get(inv, {}).get("gst_category")
place_of_supply = (
Expand All @@ -362,7 +360,6 @@ def set_outward_taxable_supplies(self):
else:
self.report_dict["sup_details"]["osup_det"]["iamt"] += taxable_value * rate / 100
self.report_dict["sup_details"]["osup_det"]["txval"] += taxable_value

if (
gst_category in ["Unregistered", "Registered Composition", "UIN Holders"]
and self.gst_details.get("gst_state") != place_of_supply.split("-")[1]
Expand Down