Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use db independent offset syntax #31345

Merged
merged 3 commits into from
Jun 14, 2022
Merged

refactor: use db independent offset syntax #31345

merged 3 commits into from
Jun 14, 2022

Conversation

c-p-b
Copy link
Contributor

@c-p-b c-p-b commented Jun 14, 2022

This syntax is supported by both MariaDB and Postgres

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. projects projects module related issue / PR labels Jun 14, 2022
@ankush ankush self-assigned this Jun 14, 2022
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jun 14, 2022
@ankush ankush changed the title chore: use db independent offset syntax refactor: use db independent offset syntax Jun 14, 2022
@ankush ankush added squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. and removed projects projects module related issue / PR labels Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #31345 (5223785) into develop (39338e7) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #31345      +/-   ##
===========================================
+ Coverage    63.57%   63.65%   +0.08%     
===========================================
  Files          984      984              
  Lines        67530    67530              
===========================================
+ Hits         42931    42987      +56     
+ Misses       24599    24543      -56     
Impacted Files Coverage Δ
erpnext/accounts/doctype/account/account.py 73.30% <ø> (ø)
...xt/accounts/doctype/journal_entry/journal_entry.py 68.95% <ø> (ø)
...xt/accounts/doctype/payment_order/payment_order.py 54.90% <ø> (ø)
...rpnext/accounts/doctype/pos_profile/pos_profile.py 65.55% <ø> (ø)
...ype/request_for_quotation/request_for_quotation.py 52.03% <ø> (ø)
erpnext/controllers/queries.py 62.31% <ø> (ø)
.../report/bom_variance_report/bom_variance_report.py 0.00% <ø> (ø)
...ext/payroll/doctype/payroll_entry/payroll_entry.py 77.09% <ø> (ø)
erpnext/projects/doctype/project/project.py 53.57% <ø> (+0.32%) ⬆️
erpnext/projects/doctype/task/task.py 65.23% <ø> (ø)
... and 34 more

@ankush ankush merged commit 00ef499 into frappe:develop Jun 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants