Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use CURRENT_DATE instead of CURDATE() #31356

Merged
merged 4 commits into from
Jun 15, 2022
Merged

refactor: use CURRENT_DATE instead of CURDATE() #31356

merged 4 commits into from
Jun 15, 2022

Conversation

c-p-b
Copy link
Contributor

@c-p-b c-p-b commented Jun 14, 2022

This syntax is supported by both postgres and mariadb

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #31356 (a2ad3d6) into develop (2a9105f) will increase coverage by 0.03%.
The diff coverage is 36.36%.

@@             Coverage Diff             @@
##           develop   #31356      +/-   ##
===========================================
+ Coverage    63.62%   63.65%   +0.03%     
===========================================
  Files          984      984              
  Lines        67550    67555       +5     
===========================================
+ Hits         42979    43004      +25     
+ Misses       24571    24551      -20     
Impacted Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 69.09% <0.00%> (ø)
...eport/inactive_sales_items/inactive_sales_items.py 0.00% <ø> (ø)
erpnext/controllers/queries.py 62.31% <ø> (ø)
.../projects/doctype/project_update/project_update.py 0.00% <ø> (ø)
...ng/report/inactive_customers/inactive_customers.py 0.00% <ø> (ø)
...eport/sales_order_analysis/sales_order_analysis.py 80.00% <ø> (ø)
erpnext/setup/doctype/email_digest/email_digest.py 25.92% <ø> (ø)
erpnext/stock/doctype/batch/batch.py 83.95% <ø> (+0.61%) ⬆️
erpnext/crm/doctype/opportunity/opportunity.py 69.58% <40.00%> (-0.19%) ⬇️
erpnext/support/doctype/issue/issue.py 65.23% <40.00%> (+0.98%) ⬆️
... and 32 more

@ankush
Copy link
Member

ankush commented Jun 15, 2022

unrelated patch failure 👀

@ankush ankush merged commit b8f728a into frappe:develop Jun 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants