feat: Cash and Non trade discounts in Sales Invoice #31405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested review from
nextchamp-saqib,
rohitwaghchaure,
marination and
ankush
as code owners
github-actions
bot
added
accounts
needs-tests
deepeshgarg007
force-pushed
the
e_invoice_discounts
branch
from
83014f5
to
b168d2f
Compare
|
Unrelated test case failing, merging this |
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Jul 4, 2022
…-31405 feat: Cash and Non trade discounts in Sales Invoice (backport #31405)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases, the discount given on Invoices on the grand total amount is not an itemized discount. Its a cash or a non-trade discount, means that this type of discount doesn't affect the tax value (GST) applied on the items and is reported on the invoice discount while E-Invoicing
If the discount applied on grand total is a Cash or Non-Trade discount user can check the "Is Cash Or Non Trade" tick and it won't be affecting any item values or have any effect on taxes else it will be considered as an itemized discount
no-docs