Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Quotation and Sales Order item sync #31446

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Jun 24, 2022

Had recently introduced partial billing status in Quotation #31322

Even after creating a Sales Order against all items of the quotation user was able to make a new Sales Order against it
Synced items between Sales Order and Quotation so that only remaining items are ordered

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 24, 2022
@deepeshgarg007
Copy link
Member Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2022

backport version-13-hotfix

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #31446 (904e69e) into develop (9c1eb77) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #31446      +/-   ##
===========================================
+ Coverage    63.79%   63.86%   +0.07%     
===========================================
  Files          986      986              
  Lines        67851    67854       +3     
===========================================
+ Hits         43285    43335      +50     
+ Misses       24566    24519      -47     
Impacted Files Coverage Δ
erpnext/selling/doctype/quotation/quotation.py 53.23% <100.00%> (+0.70%) ⬆️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...urity_shortfall/process_loan_security_shortfall.py 93.75% <0.00%> (-6.25%) ⬇️
...pnext/setup/doctype/sales_partner/sales_partner.py 65.21% <0.00%> (-4.35%) ⬇️
...pnext/stock/doctype/delivery_note/delivery_note.py 66.21% <0.00%> (-2.71%) ⬇️
.../report/bom_operations_time/bom_operations_time.py 89.13% <0.00%> (-2.18%) ⬇️
erpnext/stock/doctype/item_price/item_price.py 92.98% <0.00%> (-1.76%) ⬇️
.../fifo_queue_vs_qty_after_transaction_comparison.py 93.10% <0.00%> (-1.73%) ⬇️
erpnext/crm/doctype/prospect/prospect.py 49.25% <0.00%> (-1.50%) ⬇️
... and 25 more

@deepeshgarg007 deepeshgarg007 merged commit 173588e into frappe:develop Jun 27, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

backport version-13-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Jun 28, 2022
…-31446

fix: Quotation and Sales Order item sync (backport #31446)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant