Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't silently fail reposts in tests #31559

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

ankush
Copy link
Member

@ankush ankush commented Jul 8, 2022

Because of this silent rollback and exception handling, it's difficult to debug what's actually failing.

Discovered while debugging frappe/frappe#17350 where some generated query is invalid but no proper exception is raised.

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #31559 (926e1c7) into develop (0c2e069) will increase coverage by 0.09%.
The diff coverage is 82.78%.

@@             Coverage Diff             @@
##           develop   #31559      +/-   ##
===========================================
+ Coverage    64.58%   64.68%   +0.09%     
===========================================
  Files          965      972       +7     
  Lines        65152    65638     +486     
===========================================
+ Hits         42080    42458     +378     
- Misses       23072    23180     +108     
Impacted Files Coverage Δ
...ontract_order_summary/subcontract_order_summary.py 0.00% <0.00%> (ø)
...cturing/doctype/production_plan/production_plan.py 74.95% <ø> (ø)
...ype/repost_item_valuation/repost_item_valuation.py 69.07% <0.00%> (-0.93%) ⬇️
...ounts/doctype/purchase_invoice/purchase_invoice.py 83.23% <50.00%> (-0.25%) ⬇️
erpnext/controllers/accounts_controller.py 84.98% <50.00%> (-0.68%) ⬇️
erpnext/stock/get_item_details.py 80.20% <50.00%> (-0.18%) ⬇️
...xt/buying/doctype/purchase_order/purchase_order.py 73.41% <55.10%> (-5.88%) ⬇️
erpnext/stock/stock_ledger.py 89.86% <70.00%> (-1.33%) ⬇️
erpnext/controllers/buying_controller.py 83.95% <71.42%> (-3.90%) ⬇️
erpnext/stock/doctype/stock_entry/stock_entry.py 81.14% <71.87%> (-0.94%) ⬇️
... and 42 more

@ankush ankush merged commit 4ec85cb into frappe:develop Jul 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant