fix: Payment Request flow fixes from Order to Payment Entry #33350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deepeshgarg007
commented
Dec 15, 2022
•
deepeshgarg007
commented
- Mode of payment not getting copied from Payment Request to Payment Entry
- Unable to create Payment Entry against a Payment Request for partially paid purchase order
- Partial amount not fetching correctly in Payment Request from Purchase Order
deepeshgarg007
requested review from
rohitwaghchaure,
s-aga-r,
nextchamp-saqib and
ruthra-kumar
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33350 +/- ##
===========================================
- Coverage 64.06% 64.06% -0.01%
===========================================
Files 818 818
Lines 58661 58658 -3
===========================================
- Hits 37581 37579 -2
+ Misses 21080 21079 -1
|
|
@Mergifyio backport version-14-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Dec 20, 2022
…-33350 fix: Payment Request flow fixes from Order to Payment Entry (backport #33350)
deepeshgarg007
added a commit
that referenced
this pull request
Apr 25, 2023
* fix: Payment Request flow fixes from Order to Payment Entry (cherry picked from commit dc17898) # Conflicts: # erpnext/buying/doctype/purchase_order/purchase_order.js # erpnext/public/js/controllers/transaction.js * chore: Update test case (cherry picked from commit e25b98b) * chore: More fixes (cherry picked from commit 31c95de) * chore: resolve conflicts --------- Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
## [13.49.14](v13.49.13...v13.49.14) (2023-04-25) ### Bug Fixes * `PermissionError` in Work Order ([5680045](5680045)) * Advance payment against payment terms ([#34872](#34872)) ([d215a85](d215a85)) * internal Purchase Receipt GL Entries ([b73422e](b73422e)) * Payment entry with TDS in bank reco statement ([#34961](#34961)) ([5f28b1d](5f28b1d)) * Payment Request flow fixes from Order to Payment Entry ([#33350](#33350)) ([d5a80b5](d5a80b5)) * SLA permissions ([#34981](#34981)) ([c1187be](c1187be)) * **test:** `test_backdated_stock_reco_cancellation_future_negative_stock` ([d010b04](d010b04)) * Unable to allocate advance against invoice ([#35007](#35007)) ([61a3121](61a3121)) * use filter_by_finance_book instead of only_depreciable_assets in fixed asset register (backport [#35031](#35031)) ([#35036](#35036)) ([be2095a](be2095a)) * validation for internal transfer entry ([91b5a33](91b5a33)) * value of depreciable assets not updating after manual depr entry [v14] (backport [#35010](#35010)) ([#35029](#35029)) ([9087ac0](9087ac0)) * wrong qty of remaining work orders to be created when using "Create" > "Work Order" ([#34726](#34726)) ([189b020](189b020))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.