feat: disable currency exchange api. #33593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj12djdjs
requested review from
nextchamp-saqib,
deepeshgarg007 and
ruthra-kumar
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33593 +/- ##
===========================================
+ Coverage 64.05% 64.18% +0.12%
===========================================
Files 818 819 +1
Lines 58932 59046 +114
===========================================
+ Hits 37749 37897 +148
+ Misses 21183 21149 -34
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 179a31e)
ruthra-kumar
added a commit
that referenced
this pull request
Oct 5, 2023
…-33593 feat: disable currency exchange api. (backport #33593)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
# [14.44.0](v14.43.1...v14.44.0) (2023-10-12) ### Bug Fixes * added validation for the batch on stock reco ([#37174](#37174)) ([4c337a6](4c337a6)) * ageing summary in AR ([15d2024](15d2024)) * allocate amt for payment term invoices ([b22ac13](b22ac13)) * call validate before setting repost flag ([bec3e8e](bec3e8e)) * do not run bg job for single doc ([4123e7b](4123e7b)) * **Employee:** enable `no_copy` for `relieving_date` (backport [#37344](#37344)) ([#37358](#37358)) ([2b38b78](2b38b78)) * exception on exporting errored rows ([e58b3b1](e58b3b1)) * fetch company details for Lead based quotation ([c1d40a6](c1d40a6)) * fetch dependent task subject and project (backport [#37401](#37401)) ([#37421](#37421)) ([0aad942](0aad942)) * ignore cancelled gle in voucher-wise balance report ([#36417](#36417)) ([ee1255a](ee1255a)) * incorrect status of the returned purchase receipt ([#37300](#37300)) ([63f4573](63f4573)) * linting issues ([6c8a65e](6c8a65e)) * negative valuation rate in PR return ([#37424](#37424)) ([26ad688](26ad688)) * payment request rounding in multi-currency and on status update ([eed5863](eed5863)) * production plan reserved qty incorrect calculation (backport [#37400](#37400)) ([#37458](#37458)) ([573b159](573b159)) * split inv allocated amt on server side ([06b0477](06b0477)) * typo in doctype name and qb ([606c99e](606c99e)) * **ux:** allow MR to Stop until fully received (backport [#37452](#37452)) ([#37456](#37456)) ([fb0b426](fb0b426)) * validation for si ([3dc68e3](3dc68e3)) ### Features * add repost btn in invoice ([cde848d](cde848d)) * allow on submit fields ([f5245f6](f5245f6)) * allow repost for pi ([2d13dda](2d13dda)) * composite WIP asset ([#37352](#37352)) ([0ecd7d2](0ecd7d2)) * disable currency exchange api. ([#33593](#33593)) ([1ca0516](1ca0516)) * filter on voucher no ([cb35218](cb35218)) * introduce unreconcile doctype ([ae8355c](ae8355c)) * UI for unreconcile ([9531a45](9531a45)) * unreconcile support for journal entry ([cd2d335](cd2d335)) * validate negative stock for inventory dimension ([#37373](#37373)) ([1480aca](1480aca))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Disable currency exchange API. When disabled if no exchange records are set 0.0 will be returned.
Background
During an implementation client wants to force operator to manually enter an exchange rate. Sometimes operator forgets because exchange rate is automatically set from this API.
no-docs: There is currently no docs for Currency Exchange Settings doctype. Disabled checkbox is pretty self explanatory.