Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: additional filters and columns in Payment Ledger report #34577

Merged
merged 1 commit into from
Mar 24, 2023
Merged

refactor: additional filters and columns in Payment Ledger report #34577

merged 1 commit into from
Mar 24, 2023

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Mar 24, 2023 •
edited
Loading

  1. 'Party type' and 'Party' filters have been added
  2. checkbox to include Amount in Acccount Currency
  3. Grouping vouchers by Party
  4. Replaced Company with Posting Date

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 24, 2023
@ruthra-kumar ruthra-kumar marked this pull request as ready for review March 24, 2023 03:48
@ruthra-kumar
refactor: additional filters and columns in Payment Ledger report
4f9c11a 
1. 'Party type' and 'Party' filters have been added
2. checkbox to include Amount in Acccount Currency
3. Grouping vouchers on Party
4. Replaced Company with Posting Date
@ruthra-kumar ruthra-kumar force-pushed the payment_ledger_additional_filters_and_grouping branch from a9f3dcb to 4f9c11a Compare March 24, 2023 06:04
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #34577 (4f9c11a) into develop (ca10e2b) will decrease coverage by 0.10%.
The diff coverage is 80.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #34577      +/-   ##
===========================================
- Coverage    63.88%   63.78%   -0.10%     
===========================================
  Files          810      809       -1     
  Lines        59535    59364     -171     
===========================================
- Hits         38032    37864     -168     
+ Misses       21503    21500       -3
Impacted Files Coverage Δ
...t/accounts/report/payment_ledger/payment_ledger.py 86.95% <80.00%> (-3.27%) ⬇️

... and 11 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit f7780cd into frappe:develop Mar 24, 2023
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Mar 24, 2023 •
edited
Loading

backport version-14-hotfix

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 24, 2023
@ruthra-kumar @mergify
refactor: additional filters and columns in Payment Ledger report (#3…
57ecac4 
…4577)

1. 'Party type' and 'Party' filters have been added
2. checkbox to include Amount in Acccount Currency
3. Grouping vouchers on Party
4. Replaced Company with Posting Date

(cherry picked from commit f7780cd)
@mergify mergify bot mentioned this pull request Mar 24, 2023
Merged
ruthra-kumar added a commit that referenced this pull request Mar 24, 2023
@ruthra-kumar
Merge pull request #34583 from frappe/mergify/bp/version-14-hotfix/pr…
37f2ba8 
…-34577

refactor: additional filters and columns in Payment Ledger report (backport #34577)
@ruthra-kumar ruthra-kumar deleted the payment_ledger_additional_filters_and_grouping branch June 14, 2023 16:03
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruthra-kumar @deepeshgarg007