fix: asset monthly WDV and DD schedule [v13] #34645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbaburajan
requested review from
nextchamp-saqib,
deepeshgarg007 and
ruthra-kumar
as code owners
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
## [13.49.12](v13.49.11...v13.49.12) (2023-04-11) ### Bug Fixes * `payment entry is already created` on posawesome. (backport [#34712](#34712)) ([#34753](#34753)) ([b48fca3](b48fca3)) * Allocate tax loss to tax account head on early payment discount ([#34287](#34287)) ([92a26dd](92a26dd)) * asset monthly WDV and DD schedule [v13] ([#34645](#34645)) ([fed43ae](fed43ae)) * BOM Update Cost, when no actual qty ([9725698](9725698)) * bom update log not working for large batch size ([9cf30d7](9cf30d7)) * don't include cancelled JVs in assdeprledger report ([#34737](#34737)) ([3007ac3](3007ac3)) * enclose ternary operator in parentheses ([198830a](198830a)) * filter out old allocation's cf leaves while fetching leave details ([#34723](#34723)) ([50de045](50de045)) * format currency/float as per number format in work history ([#34545](#34545)) ([892c480](892c480)) * incorrect arg name in asset value adjustment ([545807a](545807a)) * incorrect balance qty in the stock ledger report ([dab1f1a](dab1f1a)) * Item tax validity comparison fixes ([#34784](#34784)) ([71bafab](71bafab)) * lost opportunity report issue ([#34626](#34626)) ([ab06cb4](ab06cb4)) * posting time issue ([f22e777](f22e777)) * provide filter by depreciable assets in fixed asset register ([#34803](#34803)) ([8609bf4](8609bf4)) * serial no with zero quantity issue in stock reco ([46638b1](46638b1)) * Shop by category fixes (backport [#34688](#34688)) ([#34751](#34751)) ([af828e4](af828e4)) ### Reverts * Revert "fix: `payment entry is already created` on posawesome. (#34712)" ([034e35e](034e35e)), closes [#34712](#34712) [#34712](#34712) [#34753](#34753) * remove frappe.send_message (v13) ([#34820](#34820)) ([77f1322](77f1322)), closes [#34816](#34816)
|
🎉 This PR is included in version 13.49.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Monthly depreciation calculations (i.e., with
frequency_of_depreciation= 1) for WDV and DD methods were done incorrectly -- they were calculated just like how yearly depreciation calculations were done.After:
Now, for monthly depreciation calculations for WDV and DD methods, the amounts are calculated on a yearly basis and then distributed monthly.