Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: auto fill asset name and available for use date #34660

Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore: auto fill asset name and available for use date #34660

merged 1 commit into from
Mar 30, 2023

Conversation

anandbaburajan
Copy link
Contributor

To improve UX:

  • now asset_name is set to the item_name by default
  • available_for_use_date is set to the purchase_date by default for non-existing assets

@anandbaburajan anandbaburajan merged commit a7a45fb into frappe:develop Mar 30, 2023
This was referenced Mar 30, 2023
Merged
Merged
anandbaburajan added a commit that referenced this pull request Mar 30, 2023
@mergify @anandbaburajan
chore: auto fill asset name and available for use date (backport #34660…
e54ff34 
…) (#34663)

* chore: auto fill asset name and available for use date

(cherry picked from commit af3e807)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.json

* Update asset.json

---------

Co-authored-by: anandbaburajan <anandbaburajan@gmail.com>
anandbaburajan added a commit that referenced this pull request Mar 30, 2023
@mergify @anandbaburajan
chore: auto fill asset name and available for use date (backport #34660…
8510c39 
…) (#34662)

* chore: auto fill asset name and available for use date

(cherry picked from commit af3e807)

# Conflicts:
#	erpnext/assets/doctype/asset/asset.json

* Update asset.json

---------

Co-authored-by: anandbaburajan <anandbaburajan@gmail.com>
@commit-lint commit-lint bot mentioned this pull request Apr 11, 2023
Merged
@commit-lint commit-lint bot mentioned this pull request Jul 5, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anandbaburajan