-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auto set Party in Bank Transaction #34675
Commits on Mar 31, 2023
-
feat: Party auto-matcher from Bank Transaction data
- Created Bank Party Mapper - Created class to auto match by account/iban or party name/description(fuzzy) - Automatch and set in transaction or create mapper - `rapidfuzz` introduced
Configuration menu - View commit details
-
Copy full SHA for e774503 - Browse repository at this point
Copy the full SHA e774503View commit details
Commits on Apr 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3a89828 - Browse repository at this point
Copy the full SHA 3a89828View commit details
Commits on Apr 4, 2023
-
feat: Store Party bank details in party records (Customer/Supplier/Em…
…ployee/Shareholder)
Configuration menu - View commit details
-
Copy full SHA for ad31e02 - Browse repository at this point
Copy the full SHA ad31e02View commit details -
fix: Don't set description as key in Mapper doc if matched by descrip…
…tion - Description is volatile and will keep changing - It will lead to multiple Bank Party Mapper docs for the same party that will never be referenced again - Parts of the descripton keep changing which is why it will never match a mapper record - If matched by desc, dont create mapper record.
Configuration menu - View commit details
-
Copy full SHA for 37c1331 - Browse repository at this point
Copy the full SHA 37c1331View commit details -
feat: Manually Update/Correct Party in Bank Transaction
- On updating bank trans.n party after submit, the corresponding mapper doc will be updated too - The mapper doc in turn will update all linked bank transactions that do not have this updated value - Added Bank Party Mapper hidden link in Bank Transaction - Rename field in BPM to `Party Name` as it does not hold description data - If a BT matches with a BPM record, link that record in the BT
Configuration menu - View commit details
-
Copy full SHA for 27ce789 - Browse repository at this point
Copy the full SHA 27ce789View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3360455 - Browse repository at this point
Copy the full SHA 3360455View commit details -
chore: Make auto matching party configurable
- Checkbox in Accounts settings "Enable Automatic Party Matching" - Check before invoking automatching methods - misc: Remove TODO comments
Configuration menu - View commit details
-
Copy full SHA for aea4315 - Browse repository at this point
Copy the full SHA aea4315View commit details
Commits on Apr 5, 2023
-
fix: Match by both Account No and IBAN & other cleanups
- A BT could have both account and iban, and a Supplier could have only IBAN set - In this case, matching by either (only account) gives no match - Match by Account OR IBAN, use `or_filters` - If matched, set both account no. and IBAN in Bank Party Mapper - Explain AutoMatchParty - Add type hints to return values - Use `set_value` to set values in BT after matching since its an after submit event
Configuration menu - View commit details
-
Copy full SHA for d7bc192 - Browse repository at this point
Copy the full SHA d7bc192View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcc8f9f - Browse repository at this point
Copy the full SHA fcc8f9fView commit details
Commits on Apr 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 36de35c - Browse repository at this point
Copy the full SHA 36de35cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ed8f59 - Browse repository at this point
Copy the full SHA 7ed8f59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 430b247 - Browse repository at this point
Copy the full SHA 430b247View commit details
Commits on Apr 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd38e8e - Browse repository at this point
Copy the full SHA fd38e8eView commit details
Commits on Apr 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 88647c6 - Browse repository at this point
Copy the full SHA 88647c6View commit details
Commits on May 9, 2023
-
fix: Use existing bank fields to match by bank account no/IBAN
- Remove newly added fields in Party doctypes to store bank details - Use Bank Account's fields to match against account no/iban - For employee, if Bank Account does not exist, find in Employee doctype against account no/iban
1Configuration menu - View commit details
-
Copy full SHA for dbf7a47 - Browse repository at this point
Copy the full SHA dbf7a47View commit details
Commits on May 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4a14e9e - Browse repository at this point
Copy the full SHA 4a14e9eView commit details -
feat: Optional Fuzzy Matching & Skip Matches for multiple similar mat…
…ches - Fuzzy matching can be enabled optionally in the settings - If a query gets multiple matches with the same score, do not set a party as it is an extremely close call - misc: Add 'cancelled' status to Bank transaction - Test for skipping matching with extremely close matches
Configuration menu - View commit details
-
Copy full SHA for 4364fb9 - Browse repository at this point
Copy the full SHA 4364fb9View commit details
Commits on May 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6fe5264 - Browse repository at this point
Copy the full SHA 6fe5264View commit details
Commits on Jun 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0987230 - Browse repository at this point
Copy the full SHA 0987230View commit details
Commits on Jun 6, 2023
-
chore: Remove Bank Party Mapper implementation
- Matching by Acc No/IBAN can easily happen with Bank Accounts. It's not a tedious query - Historical lookups for Party Name/Desc match are very tricky. The user could have manually set a match and we would not know. Also this leaves the Bank Party Mapper only useful for Party Name/Desc lookups, which feels excessive. - We want to reduce the number of places the same data is stored and reduce confusion - The Party Name/Desc will optionally happen fuzzily, or not at all - There will be no Mapper lookups
Configuration menu - View commit details
-
Copy full SHA for 752a92b - Browse repository at this point
Copy the full SHA 752a92bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75387bb - Browse repository at this point
Copy the full SHA 75387bbView commit details
Commits on Jun 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eb1db5e - Browse repository at this point
Copy the full SHA eb1db5eView commit details
Commits on Jun 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 51848ee - Browse repository at this point
Copy the full SHA 51848eeView commit details
Commits on Jun 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1112652 - Browse repository at this point
Copy the full SHA 1112652View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ab8230 - Browse repository at this point
Copy the full SHA 8ab8230View commit details