Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enclose ternary operator in parenthesis #34679

Merged

Conversation

ruthra-kumar
Copy link
Member

Fixing POS Credit notes having positive net total. Ternary operator wasn't enclosed properly causing this issue.

@ruthra-kumar ruthra-kumar marked this pull request as ready for review March 31, 2023 08:01
@ruthra-kumar ruthra-kumar merged commit 770640f into frappe:develop Mar 31, 2023
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-13-hotfix version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

backport version-13-hotfix version-14-hotfix

✅ Backports have been created

@ruthra-kumar ruthra-kumar changed the title fix: enclose ternary operator in parentheses fix: enclose ternary operator in parenthesis Mar 31, 2023
ruthra-kumar added a commit that referenced this pull request Mar 31, 2023
…-34679

fix: enclose ternary operator in parenthesis (backport #34679)
ruthra-kumar added a commit that referenced this pull request Mar 31, 2023
…-34679

fix: enclose ternary operator in parenthesis (backport #34679)
@ruthra-kumar ruthra-kumar deleted the fix_credit_note_with_positive_total branch June 14, 2023 16:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant