fix!: require sender and message for contact us page #34707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used override_whitelisted_method hook for the same
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34707 +/- ##
===========================================
+ Coverage 63.80% 63.84% +0.04%
===========================================
Files 810 810
Lines 59524 59657 +133
===========================================
+ Hits 37977 38087 +110
- Misses 21547 21570 +23
|
phot0n
added
backport version-13-hotfix
backport version-14-hotfix
phot0n
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
* fix: require sender and message for contact us page * refactor: dont override frappe.send_message from client side used override_whitelisted_method hook for the same (cherry picked from commit f193393)
mergify bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
* fix: require sender and message for contact us page * refactor: dont override frappe.send_message from client side used override_whitelisted_method hook for the same (cherry picked from commit f193393)
deepeshgarg007
pushed a commit
that referenced
this pull request
Apr 5, 2023
fix!: require sender and message for contact us page (#34707) * fix: require sender and message for contact us page * refactor: dont override frappe.send_message from client side used override_whitelisted_method hook for the same (cherry picked from commit f193393) Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
deepeshgarg007
pushed a commit
that referenced
this pull request
Apr 5, 2023
fix!: require sender and message for contact us page (#34707) * fix: require sender and message for contact us page * refactor: dont override frappe.send_message from client side used override_whitelisted_method hook for the same (cherry picked from commit f193393) Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: frappe/frappe#20542
Other Changes:
frappe.send_messageutil from erpnext - this was overriding the frappe.send_message util in frappe to create leads/opportunity. This is now done viaoverride_whitelisted_methodhook