fix: use CombineDatetime instead of Timestamp in QB queries
#34895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
reviewed
Apr 18, 2023
erpnext/stock/doctype/batch/batch.py
Outdated
| @@ -192,7 +192,7 @@ def get_batch_qty( | |||
| posting_time = nowtime() | |||
|
|
|||
| query = query.where( | |||
| Timestamp(sle.posting_date, sle.posting_time) <= Timestamp(posting_date, posting_time) | |||
| UnixTimestamp(sle.posting_date, sle.posting_time) <= UnixTimestamp(posting_date, posting_time) | |||
There was a problem hiding this comment.
CombineDatetime is what you're looking for not unix timestamp?
There was a problem hiding this comment.
@ankush Is there any difference between sql timestamp and frappe.qb UnixTimestamp? As we are using sql timestamp in most of the queries.
s-aga-r
force-pushed
the
use-UnixTimestamp
branch
from
2c287f7
to
91a398a
Compare
s-aga-r
changed the title
UnixTimestamp instead of Timestamp in QB queriesCombineDatetime instead of Timestamp in QB queries
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34895 +/- ##
========================================
Coverage 63.87% 63.87%
========================================
Files 810 810
Lines 59746 59746
========================================
+ Hits 38162 38163 +1
+ Misses 21584 21583 -1
|
s-aga-r
added a commit
that referenced
this pull request
Apr 20, 2023
…-34895 fix: use `CombineDatetime` instead of `Timestamp` in QB queries (backport #34895)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
TimestamptoCombineDatetimefor queries written infrappe.qb.