Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation for internal transfer entry #34980

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Apr 21, 2023

While making the internal transfer Purchase Receipt against the Delivery Note the "delivery_note_item" reference must be there in the line item. If the reference is not set then system calculates wrong valuation rate for the target warehouse.

Added validation which will throw if the "delivery_note_item" is missing in the purchase receipt line item

image

#no-docs

@rohitwaghchaure rohitwaghchaure changed the title fix: added validation for internal transfer entry fix: validation for internal transfer entry Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #34980 (19911b4) into develop (ea6eeac) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34980      +/-   ##
===========================================
+ Coverage    63.87%   63.89%   +0.01%     
===========================================
  Files          810      810              
  Lines        59750    59757       +7     
===========================================
+ Hits         38167    38179      +12     
+ Misses       21583    21578       -5     
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 85.23% <100.00%> (+0.06%) ⬆️

... and 6 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 56d62ca into frappe:develop Apr 21, 2023
rohitwaghchaure added a commit that referenced this pull request Apr 21, 2023
…-34980

fix: validation for internal transfer entry (backport #34980)
rohitwaghchaure added a commit that referenced this pull request Apr 21, 2023
…-34980

fix: validation for internal transfer entry (backport #34980)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant